chrome/browser/devtools/devtools_file_helper.cc - Issue 625113002: replace OVERRIDE and FINAL with override and final in chrome/browser/[a-i]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_file_helper.cc

Issue 625113002: replace OVERRIDE and FINAL with override and final in chrome/browser/[a-i]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix newly added OVERRIDEs Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_embedder_message_dispatcher.cc ('k') | chrome/browser/devtools/devtools_network_transaction.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_file_helper.cc

diff --git a/chrome/browser/devtools/devtools_file_helper.cc b/chrome/browser/devtools/devtools_file_helper.cc

index 04ab843e1c9650a179f76fb3328072ae909eeac4..fa6df0c7f14070cb590c33138c31b7333ccd6127 100644

--- a/chrome/browser/devtools/devtools_file_helper.cc

+++ b/chrome/browser/devtools/devtools_file_helper.cc

@@ -89,18 +89,18 @@ class SelectFileDialog : public ui::SelectFileDialog::Listener,

// ui::SelectFileDialog::Listener implementation.

virtual void FileSelected(const base::FilePath& path,

int index,

- void* params) OVERRIDE {

+ void* params) override {

selected_callback_.Run(path);

Release(); // Balanced in ::Show.

}

virtual void MultiFilesSelected(const std::vector<base::FilePath>& files,

- void* params) OVERRIDE {

+ void* params) override {

Release(); // Balanced in ::Show.

NOTREACHED() << "Should not be able to select multiple files";

}

- virtual void FileSelectionCanceled(void* params) OVERRIDE {

+ virtual void FileSelectionCanceled(void* params) override {

canceled_callback_.Run();

Release(); // Balanced in ::Show.

}