chrome/browser/content_settings/permission_bubble_request_impl.h - Issue 625113002: replace OVERRIDE and FINAL with override and final in chrome/browser/[a-i]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/permission_bubble_request_impl.h

Issue 625113002: replace OVERRIDE and FINAL with override and final in chrome/browser/[a-i]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix newly added OVERRIDEs Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/mock_settings_observer.h ('k') | chrome/browser/content_settings/permission_context_base_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/permission_bubble_request_impl.h

diff --git a/chrome/browser/content_settings/permission_bubble_request_impl.h b/chrome/browser/content_settings/permission_bubble_request_impl.h

index 3adbac101a64e601f27f7ceaff90f0666f42d917..c8eece6094e384c7b1eb490b9be9d5cdedd13cd4 100644

--- a/chrome/browser/content_settings/permission_bubble_request_impl.h

+++ b/chrome/browser/content_settings/permission_bubble_request_impl.h

@@ -34,20 +34,20 @@ class PermissionBubbleRequestImpl : public PermissionBubbleRequest {

virtual ~PermissionBubbleRequestImpl();

// PermissionBubbleRequest:

- virtual int GetIconID() const OVERRIDE;

- virtual base::string16 GetMessageText() const OVERRIDE;

- virtual base::string16 GetMessageTextFragment() const OVERRIDE;

- virtual bool HasUserGesture() const OVERRIDE;

+ virtual int GetIconID() const override;

+ virtual base::string16 GetMessageText() const override;

+ virtual base::string16 GetMessageTextFragment() const override;

+ virtual bool HasUserGesture() const override;

// TODO(miguelg) Change this method to GetOrigin()

- virtual GURL GetRequestingHostname() const OVERRIDE;

+ virtual GURL GetRequestingHostname() const override;

// Remember to call RegisterActionTaken for these methods if you are

// overriding them.

- virtual void PermissionGranted() OVERRIDE;

- virtual void PermissionDenied() OVERRIDE;

- virtual void Cancelled() OVERRIDE;

- virtual void RequestFinished() OVERRIDE;

+ virtual void PermissionGranted() override;

+ virtual void PermissionDenied() override;

+ virtual void Cancelled() override;

+ virtual void RequestFinished() override;

protected:

void RegisterActionTaken() { action_taken_ = true; }