Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: chrome/browser/diagnostics/diagnostics_writer.h

Issue 625113002: replace OVERRIDE and FINAL with override and final in chrome/browser/[a-i]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix newly added OVERRIDEs Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DIAGNOSTICS_DIAGNOSTICS_WRITER_H_ 5 #ifndef CHROME_BROWSER_DIAGNOSTICS_DIAGNOSTICS_WRITER_H_
6 #define CHROME_BROWSER_DIAGNOSTICS_DIAGNOSTICS_WRITER_H_ 6 #define CHROME_BROWSER_DIAGNOSTICS_DIAGNOSTICS_WRITER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "chrome/browser/diagnostics/diagnostics_model.h" 10 #include "chrome/browser/diagnostics/diagnostics_model.h"
(...skipping 19 matching lines...) Expand all
30 int failures() { return failures_; } 30 int failures() { return failures_; }
31 31
32 // What format are we writing things in. 32 // What format are we writing things in.
33 FormatType format() const { return format_; } 33 FormatType format() const { return format_; }
34 34
35 // Write an informational line of text in white over black. String must be 35 // Write an informational line of text in white over black. String must be
36 // UTF8 encoded. A newline will be added for non-LOG output formats. 36 // UTF8 encoded. A newline will be added for non-LOG output formats.
37 bool WriteInfoLine(const std::string& info_text); 37 bool WriteInfoLine(const std::string& info_text);
38 38
39 // DiagnosticsModel::Observer overrides 39 // DiagnosticsModel::Observer overrides
40 virtual void OnTestFinished(int index, DiagnosticsModel* model) OVERRIDE; 40 virtual void OnTestFinished(int index, DiagnosticsModel* model) override;
41 virtual void OnAllTestsDone(DiagnosticsModel* model) OVERRIDE; 41 virtual void OnAllTestsDone(DiagnosticsModel* model) override;
42 virtual void OnRecoveryFinished(int index, DiagnosticsModel* model) OVERRIDE; 42 virtual void OnRecoveryFinished(int index, DiagnosticsModel* model) override;
43 virtual void OnAllRecoveryDone(DiagnosticsModel* model) OVERRIDE; 43 virtual void OnAllRecoveryDone(DiagnosticsModel* model) override;
44 44
45 private: 45 private:
46 // Write a result block. For humans, it consists of two lines. The first line 46 // Write a result block. For humans, it consists of two lines. The first line
47 // has [PASS] or [FAIL] with |name| and the second line has the text in 47 // has [PASS] or [FAIL] with |name| and the second line has the text in
48 // |extra|. For machine and log formats, we just have [PASS] or [FAIL], 48 // |extra|. For machine and log formats, we just have [PASS] or [FAIL],
49 // followed by the exact error code and the id. Name and extra strings must be 49 // followed by the exact error code and the id. Name and extra strings must be
50 // UTF8 encoded, as they are user-facing strings. 50 // UTF8 encoded, as they are user-facing strings.
51 bool WriteResult(bool success, 51 bool WriteResult(bool success,
52 const std::string& id, 52 const std::string& id,
53 const std::string& name, 53 const std::string& name,
54 int outcome_code, 54 int outcome_code,
55 const std::string& extra); 55 const std::string& extra);
56 56
57 scoped_ptr<SimpleConsole> console_; 57 scoped_ptr<SimpleConsole> console_;
58 58
59 // Keeps track of how many tests reported failure. 59 // Keeps track of how many tests reported failure.
60 int failures_; 60 int failures_;
61 FormatType format_; 61 FormatType format_;
62 62
63 DISALLOW_COPY_AND_ASSIGN(DiagnosticsWriter); 63 DISALLOW_COPY_AND_ASSIGN(DiagnosticsWriter);
64 }; 64 };
65 65
66 } // namespace diagnostics 66 } // namespace diagnostics
67 67
68 #endif // CHROME_BROWSER_DIAGNOSTICS_DIAGNOSTICS_WRITER_H_ 68 #endif // CHROME_BROWSER_DIAGNOSTICS_DIAGNOSTICS_WRITER_H_
OLDNEW
« no previous file with comments | « chrome/browser/diagnostics/diagnostics_test.h ('k') | chrome/browser/diagnostics/diagnostics_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698