Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Side by Side Diff: chrome/browser/android/password_ui_view_android.h

Issue 625113002: replace OVERRIDE and FINAL with override and final in chrome/browser/[a-i]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix newly added OVERRIDEs Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_PASSWORD_UI_VIEW_ANDROID_H_ 5 #ifndef CHROME_BROWSER_ANDROID_PASSWORD_UI_VIEW_ANDROID_H_
6 #define CHROME_BROWSER_ANDROID_PASSWORD_UI_VIEW_ANDROID_H_ 6 #define CHROME_BROWSER_ANDROID_PASSWORD_UI_VIEW_ANDROID_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/android/jni_weak_ref.h" 10 #include "base/android/jni_weak_ref.h"
11 #include "base/android/scoped_java_ref.h" 11 #include "base/android/scoped_java_ref.h"
12 #include "chrome/browser/password_manager/password_store_factory.h" 12 #include "chrome/browser/password_manager/password_store_factory.h"
13 #include "chrome/browser/ui/passwords/password_manager_presenter.h" 13 #include "chrome/browser/ui/passwords/password_manager_presenter.h"
14 #include "chrome/browser/ui/passwords/password_ui_view.h" 14 #include "chrome/browser/ui/passwords/password_ui_view.h"
15 #include "components/password_manager/core/browser/password_store.h" 15 #include "components/password_manager/core/browser/password_store.h"
16 #include "components/password_manager/core/browser/password_store_consumer.h" 16 #include "components/password_manager/core/browser/password_store_consumer.h"
17 17
18 // PasswordUIView for Android, contains jni hooks that allows Android UI to 18 // PasswordUIView for Android, contains jni hooks that allows Android UI to
19 // display passwords and route UI commands back to native 19 // display passwords and route UI commands back to native
20 // PasswordManagerPresenter. 20 // PasswordManagerPresenter.
21 class PasswordUIViewAndroid : public PasswordUIView { 21 class PasswordUIViewAndroid : public PasswordUIView {
22 public: 22 public:
23 PasswordUIViewAndroid(JNIEnv* env, jobject); 23 PasswordUIViewAndroid(JNIEnv* env, jobject);
24 virtual ~PasswordUIViewAndroid(); 24 virtual ~PasswordUIViewAndroid();
25 25
26 // PasswordUIView implementation. 26 // PasswordUIView implementation.
27 virtual Profile* GetProfile() OVERRIDE; 27 virtual Profile* GetProfile() override;
28 virtual void ShowPassword(size_t index, const base::string16& password_value) 28 virtual void ShowPassword(size_t index, const base::string16& password_value)
29 OVERRIDE; 29 override;
30 virtual void SetPasswordList( 30 virtual void SetPasswordList(
31 const ScopedVector<autofill::PasswordForm>& password_list, 31 const ScopedVector<autofill::PasswordForm>& password_list,
32 bool show_passwords) OVERRIDE; 32 bool show_passwords) override;
33 virtual void SetPasswordExceptionList( 33 virtual void SetPasswordExceptionList(
34 const ScopedVector<autofill::PasswordForm>& password_exception_list) 34 const ScopedVector<autofill::PasswordForm>& password_exception_list)
35 OVERRIDE; 35 override;
36 36
37 // Calls from Java. 37 // Calls from Java.
38 base::android::ScopedJavaLocalRef<jobject> GetSavedPasswordEntry( 38 base::android::ScopedJavaLocalRef<jobject> GetSavedPasswordEntry(
39 JNIEnv* env, jobject, int index); 39 JNIEnv* env, jobject, int index);
40 base::android::ScopedJavaLocalRef<jstring> 40 base::android::ScopedJavaLocalRef<jstring>
41 GetSavedPasswordException(JNIEnv* env, jobject, int index); 41 GetSavedPasswordException(JNIEnv* env, jobject, int index);
42 void UpdatePasswordLists(JNIEnv* env, jobject); 42 void UpdatePasswordLists(JNIEnv* env, jobject);
43 void HandleRemoveSavedPasswordEntry(JNIEnv* env, jobject, int index); 43 void HandleRemoveSavedPasswordEntry(JNIEnv* env, jobject, int index);
44 void HandleRemoveSavedPasswordException(JNIEnv* env, jobject, int index); 44 void HandleRemoveSavedPasswordException(JNIEnv* env, jobject, int index);
45 // Destroy the native implementation. 45 // Destroy the native implementation.
46 void Destroy(JNIEnv*, jobject); 46 void Destroy(JNIEnv*, jobject);
47 47
48 // JNI registration 48 // JNI registration
49 static bool RegisterPasswordUIViewAndroid(JNIEnv* env); 49 static bool RegisterPasswordUIViewAndroid(JNIEnv* env);
50 50
51 private: 51 private:
52 PasswordManagerPresenter password_manager_presenter_; 52 PasswordManagerPresenter password_manager_presenter_;
53 // Java side of UI controller. 53 // Java side of UI controller.
54 JavaObjectWeakGlobalRef weak_java_ui_controller_; 54 JavaObjectWeakGlobalRef weak_java_ui_controller_;
55 55
56 DISALLOW_COPY_AND_ASSIGN(PasswordUIViewAndroid); 56 DISALLOW_COPY_AND_ASSIGN(PasswordUIViewAndroid);
57 }; 57 };
58 58
59 #endif // CHROME_BROWSER_ANDROID_PASSWORD_UI_VIEW_ANDROID_H_ 59 #endif // CHROME_BROWSER_ANDROID_PASSWORD_UI_VIEW_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698