Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 625073003: Replacing the OVERRIDE with override and FINAL with final in win8 folder (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
robertshield
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in win8 folder This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/f117299b515072190e4002b4ae758db9607be681 Cr-Commit-Position: refs/heads/master@{#298240}

Patch Set 1 #

Patch Set 2 : Corrected patchset-1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -63 lines) Patch
M win8/metro_driver/chrome_app_view_ash.h View 1 chunk +4 lines, -4 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M win8/metro_driver/file_picker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M win8/metro_driver/file_picker_ash.h View 3 chunks +3 lines, -3 lines 0 comments Download
M win8/metro_driver/ime/input_scope.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M win8/metro_driver/ime/input_source.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M win8/metro_driver/ime/text_service.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M win8/metro_driver/ime/text_store.h View 3 chunks +30 lines, -30 lines 0 comments Download
M win8/metro_driver/metro_driver_win7.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 06:15:06 UTC) #4
robertshield
lgtm
6 years, 2 months ago (2014-10-06 13:31:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625073003/2
6 years, 2 months ago (2014-10-06 13:31:50 UTC) #7
MRV
On 2014/10/06 13:31:09, robertshield wrote: > lgtm Thanks mr. robertshield for LGTM
6 years, 2 months ago (2014-10-06 13:49:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:2) as 0a80aff20b57190b96a9d25b3ce2faee983402e7
6 years, 2 months ago (2014-10-06 15:14:30 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 15:15:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f117299b515072190e4002b4ae758db9607be681
Cr-Commit-Position: refs/heads/master@{#298240}

Powered by Google App Engine
This is Rietveld 408576698