Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: Source/core/page/EventHandler.cpp

Issue 625073002: Merge RenderWidget into single subclass, RenderPart (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorLayerTreeAgent.cpp ('k') | Source/core/rendering/HitTestResult.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/EventHandler.cpp
diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp
index d40aac41a1ab9ee03ff5328023c6b9d29c0cc583..cd82af94b3d4ddbb6f46374344a71a34cc2cdd44 100644
--- a/Source/core/page/EventHandler.cpp
+++ b/Source/core/page/EventHandler.cpp
@@ -79,9 +79,9 @@
#include "core/rendering/HitTestResult.h"
#include "core/rendering/RenderFlowThread.h"
#include "core/rendering/RenderLayer.h"
+#include "core/rendering/RenderPart.h"
#include "core/rendering/RenderTextControlSingleLine.h"
#include "core/rendering/RenderView.h"
-#include "core/rendering/RenderWidget.h"
#include "core/rendering/style/RenderStyle.h"
#include "core/svg/SVGDocumentExtensions.h"
#include "platform/PlatformGestureEvent.h"
@@ -950,14 +950,14 @@ static LocalFrame* subframeForTargetNode(Node* node)
return 0;
RenderObject* renderer = node->renderer();
- if (!renderer || !renderer->isWidget())
+ if (!renderer || !renderer->isRenderPart())
return 0;
// FIXME: This explicit check is needed only until RemoteFrames have RemoteFrameViews.
if (isHTMLFrameElementBase(node) && toHTMLFrameElementBase(node)->contentFrame() && toHTMLFrameElementBase(node)->contentFrame()->isRemoteFrameTemporary())
return 0;
- Widget* widget = toRenderWidget(renderer)->widget();
+ Widget* widget = toRenderPart(renderer)->widget();
if (!widget || !widget->isFrameView())
return 0;
@@ -1991,8 +1991,8 @@ bool EventHandler::handleWheelEvent(const PlatformWheelEvent& event)
// Figure out which view to send the event to.
RenderObject* target = node->renderer();
- if (isOverWidget && target && target->isWidget()) {
- Widget* widget = toRenderWidget(target)->widget();
+ if (isOverWidget && target && target->isRenderPart()) {
+ Widget* widget = toRenderPart(target)->widget();
if (widget && passWheelEventToWidget(event, widget))
RETURN_WHEEL_EVENT_HANDLED();
}
@@ -2374,10 +2374,10 @@ bool EventHandler::passScrollGestureEventToWidget(const PlatformGestureEvent& ge
if (!m_lastGestureScrollOverWidget)
return false;
- if (!renderer || !renderer->isWidget())
+ if (!renderer || !renderer->isRenderPart())
return false;
- Widget* widget = toRenderWidget(renderer)->widget();
+ Widget* widget = toRenderPart(renderer)->widget();
if (!widget || !widget->isFrameView())
return false;
@@ -3853,7 +3853,7 @@ bool EventHandler::passWheelEventToWidget(const PlatformWheelEvent& wheelEvent,
bool EventHandler::passWidgetMouseDownEventToWidget(const MouseEventWithHitTestResults& event)
{
// Figure out which view to send the event to.
- if (!event.innerNode() || !event.innerNode()->renderer() || !event.innerNode()->renderer()->isWidget())
+ if (!event.innerNode() || !event.innerNode()->renderer() || !event.innerNode()->renderer()->isRenderPart())
return false;
return false;
}
« no previous file with comments | « Source/core/inspector/InspectorLayerTreeAgent.cpp ('k') | Source/core/rendering/HitTestResult.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698