Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: Source/core/html/HTMLPlugInElement.h

Issue 625073002: Merge RenderWidget into single subclass, RenderPart (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLObjectElement.cpp ('k') | Source/core/html/HTMLPlugInElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLPlugInElement.h
diff --git a/Source/core/html/HTMLPlugInElement.h b/Source/core/html/HTMLPlugInElement.h
index e12d391b2b6fc2225b31dab07c534e868a555dd7..62e5c2c9025cebb5062c47bcdbf523437326d0fb 100644
--- a/Source/core/html/HTMLPlugInElement.h
+++ b/Source/core/html/HTMLPlugInElement.h
@@ -33,7 +33,7 @@ namespace blink {
class HTMLImageLoader;
class RenderEmbeddedObject;
-class RenderWidget;
+class RenderPart;
class Widget;
enum PreferPlugInsForImagesOption {
@@ -53,7 +53,7 @@ public:
bool canProcessDrag() const;
const String& url() const { return m_url; }
- // Public for FrameView::addWidgetToUpdate()
+ // Public for FrameView::addPartToUpdate()
bool needsWidgetUpdate() const { return m_needsWidgetUpdate; }
void setNeedsWidgetUpdate(bool needsWidgetUpdate) { m_needsWidgetUpdate = needsWidgetUpdate; }
void updateWidget();
@@ -78,9 +78,9 @@ protected:
virtual bool hasFallbackContent() const;
virtual bool useFallbackContent() const;
- // Create or update the RenderWidget and return it, triggering layout if
+ // Create or update the RenderPart and return it, triggering layout if
// necessary.
- virtual RenderWidget* renderWidgetForJSBindings() const;
+ virtual RenderPart* renderPartForJSBindings() const;
bool isImageType();
bool shouldPreferPlugInsForImages() const { return m_shouldPreferPlugInsForImages; }
@@ -122,9 +122,9 @@ private:
virtual bool hasCustomFocusLogic() const override;
virtual bool isPluginElement() const override final;
- // Return any existing RenderWidget without triggering relayout, or 0 if it
+ // Return any existing RenderPart without triggering relayout, or 0 if it
// doesn't yet exist.
- virtual RenderWidget* existingRenderWidget() const = 0;
+ virtual RenderPart* existingRenderPart() const = 0;
virtual void updateWidgetInternal() = 0;
bool loadPlugin(const KURL&, const String& mimeType, const Vector<String>& paramNames, const Vector<String>& paramValues, bool useFallback, bool requireRenderer);
« no previous file with comments | « Source/core/html/HTMLObjectElement.cpp ('k') | Source/core/html/HTMLPlugInElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698