Source/core/editing/TextIterator.cpp - Issue 625073002: Merge RenderWidget into single subclass, RenderPart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/TextIterator.cpp

Issue 625073002: Merge RenderWidget into single subclass, RenderPart (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/TextIterator.cpp

diff --git a/Source/core/editing/TextIterator.cpp b/Source/core/editing/TextIterator.cpp

index 0b48f881ad8c46e93780de8646050ba26e34a898..068ad9a665e6ab79510a6f6a5e662f656a2efa0c 100644

--- a/Source/core/editing/TextIterator.cpp

+++ b/Source/core/editing/TextIterator.cpp

@@ -465,7 +465,7 @@ void TextIterator::advance()

bool handledNode = false;

if (renderer->isText() && m_node->nodeType() == Node::TEXT_NODE) { // FIXME: What about CDATA_SECTION_NODE?

handledNode = handleTextNode();

- } else if (renderer && (renderer->isImage() || renderer->isWidget()

+ } else if (renderer && (renderer->isImage() || renderer->isRenderPart()

|| (m_node && m_node->isHTMLElement()

&& (isHTMLFormControlElement(toHTMLElement(*m_node))

|| isHTMLLegendElement(toHTMLElement(*m_node))

@@ -1409,7 +1409,7 @@ void SimplifiedBackwardsTextIterator::advance()

// FIXME: What about CDATA_SECTION_NODE?

if (renderer->style()->visibility() == VISIBLE && m_offset > 0)

m_handledNode = handleTextNode();

- } else if (renderer && (renderer->isImage() || renderer->isWidget())) {

+ } else if (renderer && (renderer->isImage() || renderer->isRenderPart())) {

if (renderer->style()->visibility() == VISIBLE && m_offset > 0)

m_handledNode = handleReplacedElement();

} else {

« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/core/frame/FrameView.h » ('j') | no next file with comments »