Issue 6250123: WebUI: Change DOMUI to WebUI in two chromeos classes.

Issue 6250123: WebUI: Change DOMUI to WebUI in two chromeos classes. (Closed)

Created:
9 years, 10 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

WebUI: Change DOMUI to WebUI in two chromeos classes. BUG=59945 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73705

Patch Set 2 : avi review #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -111 lines)			Patch
M	chrome/browser/chromeos/dom_ui/menu_ui.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/menu_ui.cc	View		7 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/network_menu_ui.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/dom_ui/wrench_menu_ui.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/views/menu_locator.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/views/menu_locator.cc	View	1	12 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/chromeos/views/native_menu_domui.h	View	1	6 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/views/native_menu_domui.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
A +	chrome/browser/chromeos/views/webui_menu_widget.h	View	1	4 chunks	+11 lines, -11 lines	0 comments	Download
A +	chrome/browser/chromeos/views/webui_menu_widget.cc	View	1	12 chunks	+26 lines, -26 lines	0 comments	Download
A +	chrome/browser/chromeos/webui_menu_control.h	View		3 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

LGTM with fixes to comments since you're already in there. http://codereview.chromium.org/6250123/diff/2001/chrome/browser/chromeos/dom_ui/menu_ui.h File chrome/browser/chromeos/dom_ui/menu_ui.h (left): http://codereview.chromium.org/6250123/diff/2001/chrome/browser/chromeos/dom_ui/menu_ui.h#oldcode30 ...

9 years, 10 months ago (2011-02-03 15:09:05 UTC) #2

tfarina

9 years, 10 months ago (2011-02-03 16:37:49 UTC) #3

http://codereview.chromium.org/6250123/diff/2001/chrome/browser/chromeos/view...
File chrome/browser/chromeos/views/menu_locator.cc (right):

http://codereview.chromium.org/6250123/diff/2001/chrome/browser/chromeos/view...
chrome/browser/chromeos/views/menu_locator.cc:36: // hight, and enables
scrolling if necessary.
On 2011/02/03 15:09:05, Avi wrote:
> fix spelling of height

Done.

http://codereview.chromium.org/6250123/diff/2001/chrome/browser/chromeos/view...
File chrome/browser/chromeos/views/native_menu_domui.h (right):

http://codereview.chromium.org/6250123/diff/2001/chrome/browser/chromeos/view...
chrome/browser/chromeos/views/native_menu_domui.h:71: // Overriden from
WebUIMenuControl;
On 2011/02/03 15:09:05, Avi wrote:
> Fix spelling of Overridden.

Done.

http://codereview.chromium.org/6250123/diff/2001/chrome/browser/chromeos/view...
File chrome/browser/chromeos/views/webui_menu_widget.cc (right):

http://codereview.chromium.org/6250123/diff/2001/chrome/browser/chromeos/view...
chrome/browser/chromeos/views/webui_menu_widget.cc:107: // WebUIMenuWidgetKey.
On 2011/02/03 15:09:05, Avi wrote:
> Does the comment mean "if a given WidgetGtk instance is a WebUIMenuWidget"?
It's
> not clear what it means now.

I don't know. Oshima wrote this code.

http://codereview.chromium.org/6250123/diff/2001/chrome/browser/chromeos/view...
chrome/browser/chromeos/views/webui_menu_widget.cc:248: // Don't exeute there is
no DOMView associated. This is fine because
On 2011/02/03 15:09:05, Avi wrote:
> Fix grammar and spelling: "Don't execute if there is no..."

Done.

http://codereview.chromium.org/6250123/diff/2001/chrome/browser/chromeos/view...
File chrome/browser/chromeos/views/webui_menu_widget.h (right):

http://codereview.chromium.org/6250123/diff/2001/chrome/browser/chromeos/view...
chrome/browser/chromeos/views/webui_menu_widget.h:21: // WebUIMenuWidget is a
window widget for DOMUI based menu.
On 2011/02/03 15:09:05, Avi wrote:
> ... for a Web UI based menu.

Done.

Expand Messages | Collapse Messages