Issue 6250118: For directory upload, show empty directories (all directories, in fact) by in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6250118: For directory upload, show empty directories (all directories, in fact) by in... (Closed)

Created:
9 years, 10 months ago by John Gregg

Modified:
9 years ago

Reviewers:
jianli

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

For directory upload, show empty directories (all directories, in fact) by including the corresponding "." file in the result set. BUG=71713 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73851

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/file_select_helper.cc	View	1	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jianli

http://codereview.chromium.org/6250118/diff/1/chrome/browser/file_select_helper.cc File chrome/browser/file_select_helper.cc (right): http://codereview.chromium.org/6250118/diff/1/chrome/browser/file_select_helper.cc#newcode103 chrome/browser/file_select_helper.cc:103: directory_lister_results_.push_back(data.path.Append(".")); Have you checked if this worked for all ...

9 years, 10 months ago (2011-02-03 18:20:36 UTC) #3

John Gregg

On 2011/02/03 18:20:36, jianli wrote: > http://codereview.chromium.org/6250118/diff/1/chrome/browser/file_select_helper.cc > File chrome/browser/file_select_helper.cc (right): > > http://codereview.chromium.org/6250118/diff/1/chrome/browser/file_select_helper.cc#newcode103 > ...

9 years, 10 months ago (2011-02-03 18:26:46 UTC) #4

LGTM.

Expand Messages | Collapse Messages