Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: src/heap-inl.h

Issue 6250076: Start using store buffers. Handle store buffer overflow situation.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/gc/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap-inl.h
===================================================================
--- src/heap-inl.h (revision 6554)
+++ src/heap-inl.h (working copy)
@@ -340,7 +340,8 @@
for (int remaining = byte_size / kPointerSize;
remaining > 0;
remaining--) {
- Memory::Object_at(dst) = Memory::Object_at(src);
+ Object* data = Memory::Object_at(src);
+ Memory::Object_at(dst) = data;
Vyacheslav Egorov (Chromium) 2011/02/02 13:15:47 revert please
Erik Corry 2011/02/03 13:21:17 Done.
if (Heap::InNewSpace(Memory::Object_at(dst))) {
StoreBuffer::Mark(dst);
@@ -387,7 +388,12 @@
// If the first word is a forwarding address, the object has already been
// copied.
if (first_word.IsForwardingAddress()) {
- *p = first_word.ToForwardingAddress();
+ HeapObject* dest = first_word.ToForwardingAddress();
+ *p = dest;
+ Address cell = reinterpret_cast<Address>(p);
Vyacheslav Egorov (Chromium) 2011/02/02 13:15:47 cell is a bit confusing cause we have cell_space a
Erik Corry 2011/02/03 13:21:17 Done.
+ if (Heap::InNewSpace(dest) && !Heap::InNewSpace(cell)) {
+ StoreBuffer::EnterDirectlyIntoStoreBuffer(cell);
+ }
return;
}

Powered by Google App Engine
This is Rietveld 408576698