Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 624973004: experimental c api (Closed)

Created:
6 years, 2 months ago by reed2
Modified:
6 years, 2 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -0 lines) Patch
A experimental/sk_surface.h View 1 1 chunk +83 lines, -0 lines 1 comment Download
A experimental/sk_surface.cpp View 1 1 chunk +124 lines, -0 lines 1 comment Download

Messages

Total messages: 14 (5 generated)
reed2
6 years, 2 months ago (2014-10-05 18:03:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624973004/1
6 years, 2 months ago (2014-10-05 18:04:49 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-05 18:04:50 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 2 months ago (2014-10-06 00:04:52 UTC) #7
reed1
lgtm
6 years, 2 months ago (2014-10-06 12:58:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624973004/20001
6 years, 2 months ago (2014-10-06 12:59:07 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 938dfba51d0be03fa81866d99214447dac359e83
6 years, 2 months ago (2014-10-06 13:08:42 UTC) #11
robertphillips
https://codereview.chromium.org/624973004/diff/20001/experimental/sk_surface.h File experimental/sk_surface.h (right): https://codereview.chromium.org/624973004/diff/20001/experimental/sk_surface.h#newcode15 experimental/sk_surface.h:15: typedef struct sk_imageinfo_t { Do we not want to ...
6 years, 2 months ago (2014-10-07 16:20:27 UTC) #13
robertphillips
6 years, 2 months ago (2014-10-07 16:26:43 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/624973004/diff/20001/experimental/sk_surface.cpp
File experimental/sk_surface.cpp (right):

https://codereview.chromium.org/624973004/diff/20001/experimental/sk_surface....
experimental/sk_surface.cpp:19: 
Shouldn't these be as_rect, etc. ?

Powered by Google App Engine
This is Rietveld 408576698