Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 624903002: [fsp] Group arguments for mounting into a struct. (Closed)

Created:
6 years, 2 months ago by mtomasz
Modified:
6 years, 2 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Group arguments for mounting into a struct. The list of optional arguments is growing. Each new added one, required changes in tens of places. To resolve this problem, this CL creates a MountOptions struct. As a result adding a new optional argument to mounting will not require updating all callers. TEST=unit_tests: *FileSystemProvider* BUG=248427 Committed: https://crrev.com/00336db6f7bcdd0b540aeec83e07befed40dc15d Cr-Commit-Position: refs/heads/master@{#299434}

Patch Set 1 #

Patch Set 2 : More cleanup. #

Patch Set 3 : Cleaned up. #

Patch Set 4 : Rebased. #

Patch Set 5 : Fixed a bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -291 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 1 2 3 4 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer_unittest.cc View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc View 1 2 3 6 chunks +6 lines, -29 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/abort_unittest.cc View 1 2 3 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/close_file_unittest.cc View 1 2 3 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/copy_entry_unittest.cc View 1 2 3 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_directory_unittest.cc View 1 2 3 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_file_unittest.cc View 1 2 3 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/delete_entry_unittest.cc View 1 2 3 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/get_metadata_unittest.cc View 1 2 3 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc View 1 2 3 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/observe_directory_unittest.cc View 1 2 3 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/open_file_unittest.cc View 1 2 3 2 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_directory_unittest.cc View 1 2 3 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc View 1 2 3 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/truncate_unittest.cc View 1 2 3 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/unmount_unittest.cc View 1 2 3 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/unobserve_entry_unittest.cc View 1 2 3 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc View 1 2 3 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_info.h View 1 2 1 chunk +17 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_info.cc View 1 2 3 1 chunk +19 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc View 1 2 3 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.h View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service.cc View 1 4 chunks +13 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_unittest.cc View 1 2 3 10 chunks +28 lines, -60 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
mtomasz
@hirono: PTAL. This is a mechanical refactoring CL. Thanks.
6 years, 2 months ago (2014-10-03 08:08:01 UTC) #2
hirono
lgtm!
6 years, 2 months ago (2014-10-03 10:15:48 UTC) #3
mtomasz
On 2014/10/03 10:15:48, hirono wrote: > lgtm! @hirono: I moved extension_id out of MountOptions, and ...
6 years, 2 months ago (2014-10-03 11:43:48 UTC) #4
hirono
On 2014/10/03 11:43:48, mtomasz wrote: > On 2014/10/03 10:15:48, hirono wrote: > > lgtm! > ...
6 years, 2 months ago (2014-10-03 12:41:42 UTC) #5
mtomasz
On 2014/10/03 12:41:42, hirono wrote: > On 2014/10/03 11:43:48, mtomasz wrote: > > On 2014/10/03 ...
6 years, 2 months ago (2014-10-03 12:46:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624903002/60001
6 years, 2 months ago (2014-10-10 06:17:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/22766)
6 years, 2 months ago (2014-10-10 07:33:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624903002/60001
6 years, 2 months ago (2014-10-10 09:04:48 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/22797)
6 years, 2 months ago (2014-10-10 10:11:32 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624903002/520001
6 years, 2 months ago (2014-10-14 04:16:33 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:520001)
6 years, 2 months ago (2014-10-14 05:57:46 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 06:17:31 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/00336db6f7bcdd0b540aeec83e07befed40dc15d
Cr-Commit-Position: refs/heads/master@{#299434}

Powered by Google App Engine
This is Rietveld 408576698