Issue 62483002: Add ASSERTs in BidiResolver and RenderBlockLineLayout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62483002: Add ASSERTs in BidiResolver and RenderBlockLineLayout (Closed)

Created:
7 years, 1 month ago by igoroliveira

Modified:
7 years, 1 month ago

Reviewers:
leviw_travelin_and_unemployed, eseidel, abarth-chromium

CC:
blink-reviews, bemjb+rendering_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, zoltan1

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

constructBidiRunsForSegment: After CLs 39783004 and 46393003 if an isolated fake run is added it is always replaced with real runs. (I am being a bit conservative keeping the if statement.) BidiResolver::setStatus: When a BidiStatus is passed to BidiResolver, it needs to have a valid context. BidiRunList<Run>::reverseRuns: If reverse runs is called it should have in the least one run. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161512

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -8 lines)			Patch
M	Source/core/rendering/RenderBlockLineLayout.cpp	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	Source/platform/text/BidiResolver.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	Source/platform/text/BidiRunList.h	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/igor.o@sisa.samsung.com/62483002/1

7 years, 1 month ago (2013-11-07 07:12:26 UTC) #4

Message was sent while issue was closed.

Change committed as 161512

Expand Messages | Collapse Messages