Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 6248013: Strict mode octal literals. (Closed)

Created:
9 years, 11 months ago by Martin Maly
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Strict mode octal literals. BUG= TEST=test/mjsunit/strict-mode.js

Patch Set 1 #

Total comments: 8

Patch Set 2 : Lasse's feedback #

Total comments: 2

Patch Set 3 : More cr feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -3 lines) Patch
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/parser.cc View 1 3 chunks +17 lines, -1 line 0 comments Download
M src/scanner-base.h View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M src/scanner-base.cc View 1 2 3 chunks +8 lines, -2 lines 0 comments Download
M test/mjsunit/strict-mode.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Martin Maly
9 years, 11 months ago (2011-01-21 06:40:42 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/6248013/diff/1/src/scanner-base.cc File src/scanner-base.cc (right): http://codereview.chromium.org/6248013/diff/1/src/scanner-base.cc#newcode101 src/scanner-base.cc:101: octal_loc_.beg_pos = source_pos() - 1; // Already advanced ...
9 years, 11 months ago (2011-01-21 11:20:20 UTC) #2
MarkM
http://codereview.chromium.org/6248013/diff/1/src/scanner-base.cc File src/scanner-base.cc (right): http://codereview.chromium.org/6248013/diff/1/src/scanner-base.cc#newcode742 src/scanner-base.cc:742: if (c0_ == '\\') { // Escape sequence. On ...
9 years, 11 months ago (2011-01-21 17:44:48 UTC) #3
Martin Maly
Thanks for the review, Lasse, I changed the code accordingly, please take another peek. As ...
9 years, 11 months ago (2011-01-21 23:32:57 UTC) #4
Lasse Reichstein
LGTM http://codereview.chromium.org/6248013/diff/1/src/scanner-base.cc File src/scanner-base.cc (right): http://codereview.chromium.org/6248013/diff/1/src/scanner-base.cc#newcode742 src/scanner-base.cc:742: if (c0_ == '\\') { // Escape sequence. ...
9 years, 11 months ago (2011-01-24 07:59:37 UTC) #5
Martin Maly
Done, please let me know whether it's ok to commit. http://codereview.chromium.org/6248013/diff/6001/src/scanner-base.cc File src/scanner-base.cc (right): http://codereview.chromium.org/6248013/diff/6001/src/scanner-base.cc#newcode68 ...
9 years, 11 months ago (2011-01-24 17:21:24 UTC) #6
Lasse Reichstein
9 years, 11 months ago (2011-01-24 17:43:46 UTC) #7
It's fine, go ahead and commit!

Powered by Google App Engine
This is Rietveld 408576698