Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 6248007: Fix for ChromeFrame TypeUrl test failures on the IE9 builder. The Address bar... (Closed)

Created:
9 years, 11 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix for ChromeFrame TypeUrl test failures on the IE9 builder. The Address bar accessibility object name had changed a bit in the IE9 update. Updated the text expectations to account for this. BUG=none TEST=Existing ChromeFrame TypeUrl tests. TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome_frame/test/navigation_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 11 months ago (2011-01-16 20:26:33 UTC) #1
amit
9 years, 11 months ago (2011-01-17 04:26:09 UTC) #2
lg

On Sun, Jan 16, 2011 at 12:26 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Fix for ChromeFrame TypeUrl test failures on the IE9 builder. The Address
> bar
> accessibility
> object name had changed a bit in the IE9 update. Updated the text
> expectations
> to account for
> this.
>
> BUG=none
> TEST=Existing ChromeFrame TypeUrl tests.
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/6248007/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/navigation_test.cc
>
>
> Index: chrome_frame/test/navigation_test.cc
> ===================================================================
> --- chrome_frame/test/navigation_test.cc        (revision 71338)
> +++ chrome_frame/test/navigation_test.cc        (working copy)
> @@ -45,7 +45,7 @@
>  TEST_P(FullTabNavigationTest, TypeUrl) {
>   MockAccEventObserver acc_observer;
>   EXPECT_CALL(acc_observer, OnAccDocLoad(_)).Times(testing::AnyNumber());
> -  AccObjectMatcher address_matcher(L"Address", L"editable text");
> +  AccObjectMatcher address_matcher(L"Address*", L"editable text");
>   AccObjectMatcher go_matcher(L"Go*", L"push button");
>
>   ie_mock_.ExpectNavigation(IN_IE, GetSimplePageUrl());
> @@ -72,7 +72,7 @@
>  TEST_P(FullTabNavigationTest, TypeAnchorUrl) {
>   MockAccEventObserver acc_observer;
>   EXPECT_CALL(acc_observer, OnAccDocLoad(_)).Times(testing::AnyNumber());
> -  AccObjectMatcher address_matcher(L"Address", L"editable text");
> +  AccObjectMatcher address_matcher(L"Address*", L"editable text");
>   AccObjectMatcher go_matcher(L"Go*", L"push button");
>
>   ie_mock_.ExpectNavigation(IN_IE, GetSimplePageUrl());
>
>
>

Powered by Google App Engine
This is Rietveld 408576698