Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: common/webplugin_utils_unittest.cc

Issue 624713003: Keep only base/extractor.[cc|h]. (Closed) Base URL: https://chromium.googlesource.com/external/omaha.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « common/webplugin_utils.cc ('k') | common/xml_const.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: common/webplugin_utils_unittest.cc
diff --git a/common/webplugin_utils_unittest.cc b/common/webplugin_utils_unittest.cc
deleted file mode 100644
index c1c4e89bfbb73cac540a111885c1287b729ab0ae..0000000000000000000000000000000000000000
--- a/common/webplugin_utils_unittest.cc
+++ /dev/null
@@ -1,156 +0,0 @@
-// Copyright 2008-2009 Google Inc.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-// ========================================================================
-
-#include "omaha/base/app_util.h"
-#include "omaha/base/error.h"
-#include "omaha/base/file.h"
-#include "omaha/base/path.h"
-#include "omaha/base/utils.h"
-#include "omaha/common/webplugin_utils.h"
-#include "omaha/testing/unit_test.h"
-
-namespace omaha {
-
-namespace webplugin_utils {
-
-#define YOUTUBEUPLOADEREN_TAG \
- _T("\"appguid={A4F7B07B-B9BD-4a33-B136-96D2ADFB60CB}&") \
- _T("appname=YouTubeUploader&needsadmin=False&lang=en\"")
-
-
-TEST(WebPluginUtilsTest, BuildOneClickRequestString_NullOutParam) {
- CommandLineArgs args;
- EXPECT_EQ(E_INVALIDARG, BuildOneClickRequestString(args, NULL));
-}
-
-TEST(WebPluginUtilsTest, BuildOneClickRequestString_WrongArgs) {
- CommandLineArgs args;
- CString request;
- EXPECT_EQ(E_UNEXPECTED, BuildOneClickRequestString(args, &request));
-}
-
-TEST(WebPluginUtilsTest, BuildOneClickRequestString_NoUrlDomain) {
- CommandLineArgs args;
- CString request;
-
- args.mode = COMMANDLINE_MODE_WEBPLUGIN;
- EXPECT_EQ(E_UNEXPECTED, BuildOneClickRequestString(args, &request));
-}
-
-TEST(WebPluginUtilsTest, BuildOneClickRequestString_Valid) {
- CommandLineArgs args;
- CString request;
-
- args.mode = COMMANDLINE_MODE_WEBPLUGIN;
- args.webplugin_urldomain = _T("http://www.google.com/");
- args.webplugin_args = _T("/install \"appguid=")
- _T("{8A69D345-D564-463c-AFF1-A69D9E530F96}")
- _T("&appname=Google Chrome&needsadmin=true&lang=en\"");
- EXPECT_EQ(S_OK, BuildOneClickRequestString(args, &request));
-
- EXPECT_STREQ(_T("?du=http://www.google.com/&args=/install%20")
- _T("%22appguid=%7B8A69D345-D564-463c-AFF1-A69D9E530F96")
- _T("%7D%26appname=Google%20Chrome%26needsadmin=true%26")
- _T("lang=en%22"),
- request);
-}
-
-TEST(WebPluginUtilsTest, BuildOneClickWorkerArgs_Valid) {
- CommandLineArgs args;
- CString oneclick_args;
-
- args.install_source = _T("oneclick");
- args.webplugin_args = _T("/install \"appguid=")
- _T("{8A69D345-D564-463c-AFF1-A69D9E530F96}")
- _T("&appname=Google Chrome&needsadmin=true&lang=en\"");
- EXPECT_EQ(S_OK, BuildOneClickWorkerArgs(args, &oneclick_args));
-
- EXPECT_STREQ(_T("/install ")
- _T("\"appguid={8A69D345-D564-463c-AFF1-A69D9E530F96}")
- _T("&appname=Google Chrome&needsadmin=true&lang=en\" ")
- _T("/installsource oneclick"),
- oneclick_args);
-}
-
-// This tests valid command line args that are not valid to be sent through
-// to google_update.exe (e.g. /install).
-TEST(WebPluginUtilsTest, BuildOneClickWorkerArgs_Invalid) {
- CommandLineArgs args;
- CString oneclick_args;
-
- args.install_source = _T("oneclick");
-
- args.webplugin_args = _T("/handoff ") YOUTUBEUPLOADEREN_TAG;
- EXPECT_EQ(E_INVALIDARG, BuildOneClickWorkerArgs(args, &oneclick_args));
-
- args.webplugin_args = _T("/regserver");
- EXPECT_EQ(E_INVALIDARG, BuildOneClickWorkerArgs(args, &oneclick_args));
-
- args.webplugin_args = _T("/unregserver");
- EXPECT_EQ(E_INVALIDARG, BuildOneClickWorkerArgs(args, &oneclick_args));
-
- args.webplugin_args = _T("/install ") YOUTUBEUPLOADEREN_TAG _T(" /silent");
- EXPECT_EQ(E_INVALIDARG, BuildOneClickWorkerArgs(args, &oneclick_args));
-}
-
-TEST(WebPluginUtilsTest, CopyGoopdateToTempDir) {
- CPath current_goopdate_path(app_util::GetCurrentModuleDirectory());
- current_goopdate_path.Append(_T("unittest_support\\omaha_1.3.x\\"));
- CPath goopdate_temp_path;
- ASSERT_SUCCEEDED(CopyGoopdateToTempDir(current_goopdate_path,
- &goopdate_temp_path));
-
- std::vector<CString> files;
- EXPECT_HRESULT_SUCCEEDED(FindFilesEx(goopdate_temp_path, _T("*.*"), &files));
-
- EXPECT_EQ(3, files.size());
-
- std::map<CString, int> files_map;
- for (size_t file_index = 0; file_index < files.size(); ++file_index) {
- files_map[files[file_index]] = 1;
- }
-
- EXPECT_TRUE(files_map.find(_T("GoogleUpdate.exe")) != files_map.end());
- EXPECT_TRUE(files_map.find(_T("goopdate.dll")) != files_map.end());
- EXPECT_TRUE(files_map.find(_T("goopdateres_en.dll")) != files_map.end());
-
- EXPECT_HRESULT_SUCCEEDED(DeleteDirectory(goopdate_temp_path));
-}
-
-TEST(WebPluginUtilsTest, IsLanguageSupported_InvalidArgs) {
- CString args = _T("/en");
- EXPECT_FAILED(IsLanguageSupported(args));
-}
-
-TEST(WebPluginUtilsTest, IsLanguageSupported_LangOK) {
- CString args = _T("/install \"appguid=")
- _T("{8A69D345-D564-463c-AFF1-A69D9E530F96}")
- _T("&appname=Google Chrome&needsadmin=true&lang=en\"");
- EXPECT_SUCCEEDED(IsLanguageSupported(args));
-}
-
-TEST(WebPluginUtilsTest, IsLanguageSupported_LangNotFound) {
- CString args = _T("/install \"appguid=")
- _T("{8A69D345-D564-463c-AFF1-A69D9E530F96}")
- _T("&appname=Google Chrome&needsadmin=true&lang=zz\"");
-
- EXPECT_EQ(GOOPDATE_E_ONECLICK_LANGUAGE_NOT_SUPPORTED,
- IsLanguageSupported(args));
-}
-
-} // namespace webplugin_utils
-
-} // namespace omaha
-
« no previous file with comments | « common/webplugin_utils.cc ('k') | common/xml_const.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698