Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: statsreport/aggregator.h

Issue 624713003: Keep only base/extractor.[cc|h]. (Closed) Base URL: https://chromium.googlesource.com/external/omaha.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « standalone/standalone_installers.txt ('k') | statsreport/aggregator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: statsreport/aggregator.h
diff --git a/statsreport/aggregator.h b/statsreport/aggregator.h
deleted file mode 100644
index 02cec7268958682fae69c47063c5ce30ace3fd47..0000000000000000000000000000000000000000
--- a/statsreport/aggregator.h
+++ /dev/null
@@ -1,60 +0,0 @@
-// Copyright 2006-2009 Google Inc.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-// ========================================================================
-//
-// Helper class to aggregate the collected in-memory stats to persistent
-// storage.
-#ifndef OMAHA_STATSREPORT_AGGREGATOR_H__
-#define OMAHA_STATSREPORT_AGGREGATOR_H__
-
-#include "metrics.h"
-
-namespace stats_report {
-// TODO(omaha): Refactor to avoid cross platform code duplication.
-
-/// Wrapper class and interface for metrics aggregation. This is a platform
-/// independent class and needs to be subclassed for various platforms and/or
-/// metrics persistence methods
-class MetricsAggregator {
-public:
- /// Aggregate all metrics in the associated collection
- /// @returns true iff aggregation started successfully, false otherwise.
- bool AggregateMetrics();
-
-protected:
- MetricsAggregator();
- MetricsAggregator(const MetricCollection &coll);
- virtual ~MetricsAggregator();
-
- /// Start aggregation. Override this to grab locks, open files, whatever
- /// needs to happen or can expedite the individual aggregate steps.
- /// @return true on success, false on failure.
- /// @note aggregation will not progress if this function returns false
- virtual bool StartAggregation();
- virtual void EndAggregation();
-
- virtual void Aggregate(CountMetric &metric) = 0;
- virtual void Aggregate(TimingMetric &metric) = 0;
- virtual void Aggregate(IntegerMetric &metric) = 0;
- virtual void Aggregate(BoolMetric &metric) = 0;
-
-private:
- DISALLOW_EVIL_CONSTRUCTORS(MetricsAggregator);
-
- const MetricCollection &coll_;
-};
-
-} // namespace stats_report
-
-#endif // OMAHA_STATSREPORT_AGGREGATOR_H__
« no previous file with comments | « standalone/standalone_installers.txt ('k') | statsreport/aggregator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698