Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 624703002: Plugin Power Saver: Basic proof of concept experiment. (Closed)

Created:
6 years, 2 months ago by tommycli
Modified:
6 years, 1 month ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@0182-plugin-power-saver-add-flag
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Basic proof of concept experiment. Basic proof of experiment of Power Saver feature. Behind a flag. Builds on top of https://codereview.chromium.org/617073002/ Design doc: http://goo.gl/iDix3p BUG=403800 Committed: https://crrev.com/5576f38d2570bdbcdc1a63b50821bf4d7689ec84 Cr-Commit-Position: refs/heads/master@{#298547}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : git cl formatted #

Total comments: 33

Patch Set 4 : address comments #

Patch Set 5 : #

Total comments: 10

Patch Set 6 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -8 lines) Patch
M content/content_renderer.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 2 3 3 chunks +15 lines, -0 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 2 3 4 5 9 chunks +54 lines, -8 lines 0 comments Download
A content/renderer/pepper/pepper_plugin_instance_throttler.h View 1 2 3 4 5 1 chunk +29 lines, -0 lines 0 comments Download
A content/renderer/pepper/pepper_plugin_instance_throttler.cc View 1 2 3 4 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (5 generated)
tommycli
raymes: PTAL
6 years, 2 months ago (2014-10-02 23:54:31 UTC) #2
tommycli
cpu: Hi Carlos, the Pepper guys wanted to make sure you were aware that code ...
6 years, 2 months ago (2014-10-03 23:09:24 UTC) #4
groby-ooo-7-16
More drive-by :) https://codereview.chromium.org/624703002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/624703002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode1112 content/renderer/pepper/pepper_plugin_instance_impl.cc:1112: if (plugin_throttled_) How does this interact ...
6 years, 2 months ago (2014-10-06 17:39:44 UTC) #6
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/624703002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/624703002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode408 content/renderer/pepper/pepper_plugin_instance_impl.cc:408: bool is_peripheral_content = true; so we are going to ...
6 years, 2 months ago (2014-10-06 18:07:52 UTC) #7
groby-ooo-7-16
https://codereview.chromium.org/624703002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/624703002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode408 content/renderer/pepper/pepper_plugin_instance_impl.cc:408: bool is_peripheral_content = true; On 2014/10/06 18:07:52, cpu wrote: ...
6 years, 2 months ago (2014-10-06 18:13:13 UTC) #8
raymes
https://codereview.chromium.org/624703002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/624703002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode409 content/renderer/pepper/pepper_plugin_instance_impl.cc:409: bool enable_power_saver = is_peripheral_content && Can we restrict this ...
6 years, 2 months ago (2014-10-06 18:21:48 UTC) #9
tommycli
raymes/cpu/groby: addressed your comments. Thanks! https://codereview.chromium.org/624703002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/624703002/diff/40001/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode408 content/renderer/pepper/pepper_plugin_instance_impl.cc:408: bool is_peripheral_content = true; ...
6 years, 2 months ago (2014-10-06 22:52:14 UTC) #10
tommycli
+cc thestig
6 years, 2 months ago (2014-10-06 22:52:50 UTC) #12
raymes
lgtm with nits https://codereview.chromium.org/624703002/diff/80001/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/624703002/diff/80001/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode1116 content/renderer/pepper/pepper_plugin_instance_impl.cc:1116: } nit: don't need {} https://codereview.chromium.org/624703002/diff/80001/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode1123 ...
6 years, 2 months ago (2014-10-06 23:26:03 UTC) #13
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/624703002/diff/80001/content/renderer/pepper/pepper_plugin_instance_throttler.h File content/renderer/pepper/pepper_plugin_instance_throttler.h (right): https://codereview.chromium.org/624703002/diff/80001/content/renderer/pepper/pepper_plugin_instance_throttler.h#newcode10 content/renderer/pepper/pepper_plugin_instance_throttler.h:10: #include "base/memory/weak_ptr.h" do you need macros.h or weak_ptr.h ...
6 years, 2 months ago (2014-10-06 23:46:01 UTC) #14
tommycli
raymes/cpu: thanks@ https://codereview.chromium.org/624703002/diff/80001/content/renderer/pepper/pepper_plugin_instance_impl.cc File content/renderer/pepper/pepper_plugin_instance_impl.cc (right): https://codereview.chromium.org/624703002/diff/80001/content/renderer/pepper/pepper_plugin_instance_impl.cc#newcode1116 content/renderer/pepper/pepper_plugin_instance_impl.cc:1116: } On 2014/10/06 23:26:02, raymes wrote: > ...
6 years, 2 months ago (2014-10-07 18:20:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624703002/100001
6 years, 2 months ago (2014-10-07 18:21:16 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001) as e4db8f64f5dbbedb681ea757ff5c4fbb42e52d0c
6 years, 2 months ago (2014-10-07 19:56:21 UTC) #18
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 19:57:05 UTC) #19
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/5576f38d2570bdbcdc1a63b50821bf4d7689ec84
Cr-Commit-Position: refs/heads/master@{#298547}

Powered by Google App Engine
This is Rietveld 408576698