Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2018)

Unified Diff: src/IceTargetLowering.h

Issue 624663002: Introduce model of global initializers in Subzero. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: add more tests. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceTargetLowering.h
diff --git a/src/IceTargetLowering.h b/src/IceTargetLowering.h
index 82d0f59c30dde923cc12d84105b32218f074c48e..d0c091862066a600c05fa43f3a23fbfca0444966 100644
--- a/src/IceTargetLowering.h
+++ b/src/IceTargetLowering.h
@@ -19,6 +19,7 @@
#define SUBZERO_SRC_ICETARGETLOWERING_H
#include "IceDefs.h"
+#include "IceGlobalInits.h"
Jim Stichnoth 2014/10/06 18:16:38 I think it's best to try to minimize includes in a
Karl 2014/10/06 22:44:04 Done.
#include "IceInst.h" // for the names of the Inst subtypes
#include "IceTypes.h"
@@ -248,10 +249,7 @@ public:
GlobalContext *Ctx);
virtual ~TargetGlobalInitLowering();
- // TODO: Allow relocations to be represented as part of the Data.
- virtual void lower(const IceString &Name, SizeT Align, bool IsInternal,
- bool IsConst, bool IsZeroInitializer, SizeT Size,
- const char *Data, bool DisableTranslation) = 0;
+ virtual void lower(const GlobalAddress &Addr, bool DisableTranslation) = 0;
protected:
TargetGlobalInitLowering(GlobalContext *Ctx) : Ctx(Ctx) {}

Powered by Google App Engine
This is Rietveld 408576698