tests_lit/llvm2ice_tests/global.ll - Issue 624663002: Introduce model of global initializers in Subzero.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests_lit/llvm2ice_tests/global.ll

Issue 624663002: Introduce model of global initializers in Subzero. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix issues in patch set 4. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 ; Trivial test of the use of internal versus external global	1 ; Trivial test of the use of internal versus external global

2 ; variables.	2 ; variables.

3	3

4 ; TODO(kschimpf) find out why lc2i is needed.	4 ; TODO(kschimpf) find out why lc2i is needed.

5 ; RUN: %lc2i -i %s --args --verbose inst \| FileCheck %s	5 ; RUN: %lc2i -i %s --args --verbose inst \| FileCheck %s
	jvoung (off chromium) 2014/10/07 15:35:31 Does removing the external, or having this new mod Does removing the external, or having this new model happen to fix lc2i? Don't worry about it for this CL if it doesn't... I'm just checking. Karl 2014/10/07 15:56:22 The reason this test was failing to work in p2i wa Show quoted text On 2014/10/07 15:35:31, jvoung wrote: > Does removing the external, or having this new model happen to fix lc2i? Don't > worry about it for this CL if it doesn't... I'm just checking. The reason this test was failing to work in p2i was because of the external. l2ci (i.e. the IceConverter) still allows external symbols. This is intentional. It makes doing certain types of cross tool tests possible. That is, it allows us a way to compile the same external reference using llvm2ice and llc, allowing us to test if they behave the same way.
6 ; RUN: %lc2i -i %s --args --verbose none \| FileCheck --check-prefix=ERRORS %s	6 ; RUN: %lc2i -i %s --args --verbose none \| FileCheck --check-prefix=ERRORS %s

7	7

	8 ; Note: PNaCl ABI Doesn't allow external globals. Hence, not tested.

8 @intern_global = internal global [4 x i8] c"\00\00\00\0C", align 4	9 @intern_global = internal global [4 x i8] c"\00\00\00\0C", align 4

9 @extern_global = external global [4 x i8]

10	10

11 define i32 @test_intern_global() {	11 define i32 @test_intern_global() {

12 ; CHECK: define i32 @test_intern_global	12 ; CHECK: define i32 @test_intern_global

13 entry:	13 entry:

14 %__1 = bitcast [4 x i8]* @intern_global to i32*	14 %__1 = bitcast [4 x i8]* @intern_global to i32*

15 %v0 = load i32* %__1, align 1	15 %v0 = load i32* %__1, align 1

16 ret i32 %v0	16 ret i32 %v0

17 }	17 }

18	18

19 define i32 @test_extern_global() {

20 ; CHECK: define i32 @test_extern_global

21 entry:

22 %__1 = bitcast [4 x i8]* @extern_global to i32*

23 %v0 = load i32* %__1, align 1

24 ret i32 %v0

25 }

26

27 ; ERRORS-NOT: ICE translation error	19 ; ERRORS-NOT: ICE translation error

OLD	NEW

« src/PNaClTranslator.cpp ('K') | « src/llvm2ice.cpp ('k') | tests_lit/llvm2ice_tests/unnamed.ll » ('j') | tests_lit/reader_tests/globalrelocs.ll » ('J')