Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 6246123: Moving psutil to third_party. This is first step for Media Performance test project. (Closed)

Created:
9 years, 10 months ago by imasaki1
Modified:
9 years, 6 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews
Visibility:
Public.

Description

Moving psutil to third_party. This is first step for Media Performance test project. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74047

Patch Set 1 #

Total comments: 2

Patch Set 2 : modification based on code review's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10564 lines, -0 lines) Patch
A third_party/psutil/CREDITS View 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/psutil/HISTORY View 1 chunk +152 lines, -0 lines 0 comments Download
A third_party/psutil/LICENSE View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/psutil/MANIFEST.in View 1 chunk +9 lines, -0 lines 0 comments Download
A third_party/psutil/PKG-INFO View 1 chunk +40 lines, -0 lines 0 comments Download
A third_party/psutil/README View 1 chunk +118 lines, -0 lines 0 comments Download
A third_party/psutil/README.chromium View 1 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/psutil/docs/class_diagram.dia View 1 chunk +1475 lines, -0 lines 0 comments Download
A third_party/psutil/docs/class_diagram.png View Binary file 0 comments Download
A third_party/psutil/docs/documentation.html View 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/psutil/docs/index.html View 1 chunk +99 lines, -0 lines 0 comments Download
A third_party/psutil/docs/milestones.lnk.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/__init__.py View 1 chunk +543 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psbsd.py View 1 chunk +157 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_pslinux.py View 1 chunk +471 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psmswindows.py View 1 chunk +215 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psosx.py View 1 chunk +157 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psposix.py View 1 chunk +240 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psutil_bsd.h View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psutil_bsd.c View 1 chunk +566 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psutil_mswindows.h View 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psutil_mswindows.c View 1 chunk +1655 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psutil_osx.h View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/_psutil_osx.c View 1 chunk +689 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/arch/bsd/process_info.h View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/arch/bsd/process_info.c View 1 chunk +244 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/arch/mswindows/process_handles.h View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/arch/mswindows/process_handles.c View 1 chunk +295 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/arch/mswindows/process_info.h View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/arch/mswindows/process_info.c View 1 chunk +479 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/arch/mswindows/security.h View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/arch/mswindows/security.c View 1 1 chunk +233 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/arch/osx/process_info.h View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/arch/osx/process_info.c View 1 chunk +301 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/compat.py View 1 chunk +111 lines, -0 lines 0 comments Download
A third_party/psutil/psutil/error.py View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/psutil/setup.py View 1 chunk +110 lines, -0 lines 0 comments Download
A third_party/psutil/test/_bsd.py View 1 chunk +136 lines, -0 lines 0 comments Download
A third_party/psutil/test/_linux.py View 1 chunk +45 lines, -0 lines 0 comments Download
A third_party/psutil/test/_osx.py View 1 chunk +64 lines, -0 lines 0 comments Download
A third_party/psutil/test/_posix.py View 1 chunk +139 lines, -0 lines 0 comments Download
A third_party/psutil/test/_windows.py View 1 chunk +162 lines, -0 lines 0 comments Download
A third_party/psutil/test/test_memory_leaks.py View 1 chunk +188 lines, -0 lines 0 comments Download
A third_party/psutil/test/test_psutil.py View 1 chunk +1062 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nirnimesh
http://codereview.chromium.org/6246123/diff/1/third_party/psutil/README.google File third_party/psutil/README.google (right): http://codereview.chromium.org/6246123/diff/1/third_party/psutil/README.google#newcode1 third_party/psutil/README.google:1: URL: http://code.google.com/p/psutil/ Rename file to README.chromium Begin file with ...
9 years, 10 months ago (2011-02-04 23:15:02 UTC) #1
Nirnimesh
LGTM. I'd suggest replacing 'Moving psutil to third_party' in title with 'Adding psutil to third_party'
9 years, 10 months ago (2011-02-05 01:38:22 UTC) #2
Nirnimesh
On 2011/02/05 01:38:22, Nirnimesh wrote: > LGTM. > > I'd suggest replacing 'Moving psutil to ...
9 years, 10 months ago (2011-02-05 01:56:47 UTC) #3
Nirnimesh
9 years, 10 months ago (2011-02-07 23:52:59 UTC) #4
On 2011/02/05 01:56:47, Nirnimesh wrote:
> On 2011/02/05 01:38:22, Nirnimesh wrote:
> > LGTM.
> > 
> > I'd suggest replacing 'Moving psutil to third_party' in title with 'Adding
> > psutil to third_party'
> 
> I just noticed that this CL is based at trunk.
> Shouldn't it be rooted at trunk/src?

Never mind. I managed to commit it.

Powered by Google App Engine
This is Rietveld 408576698