Issue 6246025: Fix the heuristic to find depot_tools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6246025: Fix the heuristic to find depot_tools (Closed)

Created:
9 years, 10 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Dirk Pranke

CC:
chromium-reviews, Nicolas Sylvain, Peter Mayo (wrong one)

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/commit-queue

Visibility:
Public.

Description

Fix the heuristic to find depot_tools BUG=none TEST=commit_queue.py works without depot_tools in PATH TBR=dpranke Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73455

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	find_depot_tools.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

LGTM. Are you sure you don't want to raise an error or call sys.exit() in ...

9 years, 10 months ago (2011-02-02 20:04:29 UTC) #4

M-A Ruel

9 years, 10 months ago (2011-02-02 20:06:15 UTC) #5

On 2011/02/02 20:04:29, dpranke wrote:
> LGTM. Are you sure you don't want to raise an error or call sys.exit() in this
> situation?

Good question. But the code will fail eventually so I don't mind too much and I
don't think it warrants extra code there.

Expand Messages | Collapse Messages