Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 624563002: Files.app: Rename Rect used in Gallery with ImageRect. (Closed)

Created:
6 years, 2 months ago by hirono
Modified:
6 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Rename Rect used in Gallery with ImageRect. The name conflicts with CSS's Rect. BUG=419360 TEST=None Committed: https://crrev.com/f0f88c8ba80bcc129de055b747e21d7dcf278621 Cr-Commit-Position: refs/heads/master@{#297797}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebase again. #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -113 lines) Patch
M ui/file_manager/gallery/js/image_editor/commands.js View 3 chunks +5 lines, -4 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_editor.js View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_transform.js View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_util.js View 11 chunks +47 lines, -45 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_view.js View 10 chunks +13 lines, -11 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/viewport.js View 14 chunks +30 lines, -29 lines 0 comments Download
M ui/file_manager/gallery/js/mosaic_mode.js View 5 chunks +13 lines, -13 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
hirono
PTAL the CL? Thank you!
6 years, 2 months ago (2014-10-02 04:04:40 UTC) #2
fukino
On 2014/10/02 04:04:40, hirono wrote: > PTAL the CL? Thank you! Looks good to me. ...
6 years, 2 months ago (2014-10-02 04:45:31 UTC) #3
fukino
On 2014/10/02 04:45:31, fukino wrote: > On 2014/10/02 04:04:40, hirono wrote: > > PTAL the ...
6 years, 2 months ago (2014-10-02 04:45:39 UTC) #4
hirono
On 2014/10/02 04:45:39, fukino wrote: > On 2014/10/02 04:45:31, fukino wrote: > > On 2014/10/02 ...
6 years, 2 months ago (2014-10-02 07:38:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624563002/1
6 years, 2 months ago (2014-10-02 07:39:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14927)
6 years, 2 months ago (2014-10-02 07:47:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624563002/20001
6 years, 2 months ago (2014-10-02 07:50:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/4316) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/21038)
6 years, 2 months ago (2014-10-02 07:58:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624563002/40001
6 years, 2 months ago (2014-10-02 08:15:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/21045) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/15790)
6 years, 2 months ago (2014-10-02 08:22:21 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624563002/50001
6 years, 2 months ago (2014-10-02 09:36:02 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:50001) as 59ed3baae3f846b2aab2bc697539a32ce2158e4c
6 years, 2 months ago (2014-10-02 10:16:10 UTC) #20
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 10:17:06 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/f0f88c8ba80bcc129de055b747e21d7dcf278621
Cr-Commit-Position: refs/heads/master@{#297797}

Powered by Google App Engine
This is Rietveld 408576698