Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 62453002: Don't verify the policy timestamp when loading from cache. (Closed)

Created:
7 years, 1 month ago by Joao da Silva
Modified:
7 years, 1 month ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Don't verify the policy timestamp when loading from cache. There are conditions that cause a device's clock to go back in time, and then if the policy is rejected because its timestamp is in the future then no user can sign-in, and guest sessions can't be started. This CL removes the timestamp check from policies loaded from the cache; new policies downloaded from the server or downloaded during enrollment still have their timestamps checked. BUG=313906, 265507, 303508 R=bartfab@chromium.org, xiyuan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233323

Patch Set 1 #

Total comments: 1

Patch Set 2 : s/if/is #

Patch Set 3 : also skip timestamp checks for public accounts policy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -10 lines) Patch
M chrome/browser/chromeos/policy/device_local_account_policy_store.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_policy_store.cc View 1 2 4 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation.cc View 1 1 chunk +15 lines, -7 lines 0 comments Download
M chrome/browser/policy/cloud/cloud_policy_validator.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Joao da Silva
Bartosz, please have a first look at this. Thanks!
7 years, 1 month ago (2013-11-06 17:51:01 UTC) #1
bartfab (slow)
lgtm https://codereview.chromium.org/62453002/diff/1/chrome/browser/chromeos/settings/session_manager_operation.cc File chrome/browser/chromeos/settings/session_manager_operation.cc (right): https://codereview.chromium.org/62453002/diff/1/chrome/browser/chromeos/settings/session_manager_operation.cc#newcode177 chrome/browser/chromeos/settings/session_manager_operation.cc:177: // verified during enrollment and when a new ...
7 years, 1 month ago (2013-11-06 17:53:51 UTC) #2
Joao da Silva
chromeos/OWNERS: can one of you stamp this fix? It's meant to go back to M31. ...
7 years, 1 month ago (2013-11-06 18:02:31 UTC) #3
xiyuan
lgtm
7 years, 1 month ago (2013-11-06 19:09:23 UTC) #4
bartfab (slow)
lgtm
7 years, 1 month ago (2013-11-06 19:21:28 UTC) #5
Joao da Silva
7 years, 1 month ago (2013-11-06 19:25:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r233323 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698