Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 624503002: Avoid sending WINDOW_CONTENT_CHANGED more than once when frame info changes. (Closed)

Created:
6 years, 2 months ago by dmazzoni
Modified:
6 years, 2 months ago
Reviewers:
Peter Lundblad
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Avoid sending WINDOW_CONTENT_CHANGED more than once when frame info changes. Use a boolean to only send WINDOW_CONTENT_CHANGED the first time notifyFrameInfoInitialized is called. See bug for longer discussion of issue. BUG=419541 Committed: https://crrev.com/b2298d533e44537313c2d071064e024af2eba70d Cr-Commit-Position: refs/heads/master@{#297824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dmazzoni
6 years, 2 months ago (2014-10-01 21:31:16 UTC) #2
Peter Lundblad
Hi, This makes total sense if any following call wouldn't imply any change to the ...
6 years, 2 months ago (2014-10-02 09:22:44 UTC) #3
Peter Lundblad
lgtm
6 years, 2 months ago (2014-10-02 09:23:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624503002/1
6 years, 2 months ago (2014-10-02 09:24:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/14959)
6 years, 2 months ago (2014-10-02 09:33:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624503002/1
6 years, 2 months ago (2014-10-02 13:30:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as b10d4e5ddee839230ce1f3159216bef1c2fdff72
6 years, 2 months ago (2014-10-02 13:39:59 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 13:40:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b2298d533e44537313c2d071064e024af2eba70d
Cr-Commit-Position: refs/heads/master@{#297824}

Powered by Google App Engine
This is Rietveld 408576698