Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 624483002: Make TextIterator not stop at IMG element for finding text separating inline image (Closed)

Created:
6 years, 2 months ago by c.shu
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

In text iterator, the SearchBuffer is reset when the iterator passes through a 0-length boundary, such as IMG element. This causes failure to find texts containing parts from both before and after the image. BUG=419524 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183345

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1

Patch Set 3 : address review comments #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M LayoutTests/editing/text-iterator/findString.html View 2 chunks +3 lines, -1 line 0 comments Download
M LayoutTests/editing/text-iterator/findString-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/editing/TextIterator.h View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M Source/core/editing/TextIterator.cpp View 1 2 3 4 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (4 generated)
c.shu
6 years, 2 months ago (2014-10-01 21:07:26 UTC) #2
haraken
ccing editing experts.
6 years, 2 months ago (2014-10-01 23:28:55 UTC) #4
yosin_UTC9
Please change "Subject" to something like "Make TextIterator not stop at IMG element for finding ...
6 years, 2 months ago (2014-10-02 01:43:06 UTC) #6
mlamouri (slow - plz ping)
Some clients might even be interested to get the |alt| text instead of the image. ...
6 years, 2 months ago (2014-10-02 10:44:26 UTC) #7
c.shu
On 2014/10/02 01:43:06, Yosi_UTC9 wrote: > Please change "Subject" to something like "Make TextIterator not ...
6 years, 2 months ago (2014-10-02 15:08:51 UTC) #8
c.shu
addressed review comments.
6 years, 2 months ago (2014-10-02 17:50:58 UTC) #9
yosin_UTC9
Please limit this change to affect Find-In-Page feature only. https://codereview.chromium.org/624483002/diff/20001/Source/core/editing/TextIterator.cpp File Source/core/editing/TextIterator.cpp (right): https://codereview.chromium.org/624483002/diff/20001/Source/core/editing/TextIterator.cpp#newcode1751 Source/core/editing/TextIterator.cpp:1751: ...
6 years, 2 months ago (2014-10-03 07:53:56 UTC) #10
c.shu
6 years, 2 months ago (2014-10-03 18:59:19 UTC) #11
Yuta Kitamura
LGTM after revision; naming should be fixed before landing. https://codereview.chromium.org/624483002/diff/40001/Source/core/editing/TextIterator.h File Source/core/editing/TextIterator.h (right): https://codereview.chromium.org/624483002/diff/40001/Source/core/editing/TextIterator.h#newcode50 Source/core/editing/TextIterator.h:50: ...
6 years, 2 months ago (2014-10-07 09:51:30 UTC) #12
Yuta Kitamura
Also, please wrap the change description text in every 80 characters or so. Unwrapped text ...
6 years, 2 months ago (2014-10-07 09:54:39 UTC) #13
c.shu
Thanks for the review! https://codereview.chromium.org/624483002/diff/40001/Source/core/editing/TextIterator.h File Source/core/editing/TextIterator.h (right): https://codereview.chromium.org/624483002/diff/40001/Source/core/editing/TextIterator.h#newcode50 Source/core/editing/TextIterator.h:50: TextIteratorNotBreakAtZeroLengthBoundary = 1 << 8 ...
6 years, 2 months ago (2014-10-07 14:30:26 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624483002/60001
6 years, 2 months ago (2014-10-07 14:39:22 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 15:47:18 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as 183345

Powered by Google App Engine
This is Rietveld 408576698