Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: runtime/vm/assembler_ia32.cc

Issue 624473003: - Update the header word atomically on ia32. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/stub_code_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.cc
===================================================================
--- runtime/vm/assembler_ia32.cc (revision 40852)
+++ runtime/vm/assembler_ia32.cc (working copy)
@@ -2212,13 +2212,17 @@
StoreIntoObjectFilterNoSmi(object, value, &done);
}
// A store buffer update is required.
- if (value != EAX) pushl(EAX); // Preserve EAX.
- if (object != EAX) {
- movl(EAX, object);
+ if (value != EDX) {
+ pushl(EDX); // Preserve EDX.
}
+ if (object != EDX) {
+ movl(EDX, object);
+ }
StubCode* stub_code = Isolate::Current()->stub_code();
call(&stub_code->UpdateStoreBufferLabel());
- if (value != EAX) popl(EAX); // Restore EAX.
+ if (value != EDX) {
+ popl(EDX); // Restore EDX.
+ }
Bind(&done);
}
« no previous file with comments | « no previous file | runtime/vm/stub_code_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698