Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: components/cronet/android/url_request_context_adapter.h

Issue 624443003: Setup ProxyConfigServiceAndroid in Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix an indentation Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/url_request_context_adapter.h
diff --git a/components/cronet/android/url_request_context_adapter.h b/components/cronet/android/url_request_context_adapter.h
index b84e036f3cb476e8d70acfa6164c7eef4f94da47..70bf3d82e1c75953450a850aee1479add4f5725e 100644
--- a/components/cronet/android/url_request_context_adapter.h
+++ b/components/cronet/android/url_request_context_adapter.h
@@ -17,6 +17,7 @@
#include "base/threading/thread.h"
#include "net/base/net_log.h"
#include "net/base/network_change_notifier.h"
+#include "net/proxy/proxy_config_service.h"
#include "net/url_request/url_request_context.h"
#include "net/url_request/url_request_context_getter.h"
@@ -80,6 +81,9 @@ class URLRequestContextAdapter : public net::URLRequestContextGetter {
void StartNetLogToFile(const std::string& file_name);
void StopNetLog();
+ // Called on main java UI thread to initialize URLRequestContext.
mmenke 2014/10/15 17:44:18 nit: Java
xunjieli 2014/10/15 19:48:09 Done.
+ void InitRequestContextOnUIThread();
mmenke 2014/10/15 17:44:18 Should this be Main thread? I don't see the main
xunjieli 2014/10/15 19:48:09 Done.
+
private:
scoped_refptr<URLRequestContextAdapterDelegate> delegate_;
scoped_ptr<net::URLRequestContext> context_;
@@ -88,6 +92,8 @@ class URLRequestContextAdapter : public net::URLRequestContextGetter {
scoped_ptr<net::NetworkChangeNotifier> network_change_notifier_;
scoped_ptr<NetLogObserver> net_log_observer_;
scoped_ptr<net::NetLogLogger> net_log_logger_;
+ scoped_ptr<net::ProxyConfigService> proxy_config_service_;
+ scoped_ptr<URLRequestContextConfig> config_;
// A queue of tasks that need to be run after context has been initialized.
std::queue<RunAfterContextInitTask> tasks_waiting_for_context_;
@@ -96,7 +102,8 @@ class URLRequestContextAdapter : public net::URLRequestContextGetter {
virtual ~URLRequestContextAdapter();
// Initializes |context_| on the Network thread.
- void InitializeURLRequestContext(scoped_ptr<URLRequestContextConfig> config);
+ void InitRequestContextOnNetworkThread(
+ scoped_ptr<URLRequestContextConfig> config);
// Helper function to start writing NetLog data to file. This should only be
// run after context is initialized.

Powered by Google App Engine
This is Rietveld 408576698