components/cronet/android/chromium_url_request_context.cc - Issue 624443003: Setup ProxyConfigServiceAndroid in Cronet

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/cronet/android/chromium_url_request_context.cc

Issue 624443003: Setup ProxyConfigServiceAndroid in Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java » ('j') | components/cronet/android/java/src/org/chromium/net/ChromiumUrlRequestContext.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/cronet/android/chromium_url_request_context.h"	5 #include "components/cronet/android/chromium_url_request_context.h"

6	6

7 #include <string>	7 #include <string>

8	8

9 #include "base/android/jni_android.h"	9 #include "base/android/jni_android.h"

10 #include "base/android/jni_string.h"	10 #include "base/android/jni_string.h"

(...skipping 129 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
140	140

141 // Stops recording NetLog.	141 // Stops recording NetLog.

142 static void StopNetLog(JNIEnv* env,	142 static void StopNetLog(JNIEnv* env,

143 jobject jcaller,	143 jobject jcaller,

144 jlong urlRequestContextAdapter) {	144 jlong urlRequestContextAdapter) {

145 URLRequestContextAdapter* adapter =	145 URLRequestContextAdapter* adapter =

146 reinterpret_cast<URLRequestContextAdapter*>(urlRequestContextAdapter);	146 reinterpret_cast<URLRequestContextAdapter*>(urlRequestContextAdapter);

147 adapter->StopNetLog();	147 adapter->StopNetLog();

148 }	148 }

149	149

	150 // Called on application's main UI thread.

	151 static void InitRequestContext(
	mef 2014/10/10 21:20:37 I would call this InitRequestContextOnUIThread for I would call this InitRequestContextOnUIThread for explicity and consistency. xunjieli 2014/10/14 19:14:48 Done. Show quoted text On 2014/10/10 21:20:37, mef wrote: > I would call this InitRequestContextOnUIThread for explicity and consistency. Done.
	152 JNIEnv* env,

	153 jobject jcaller,

	154 jlong urlRequestContextAdapter) {

	155 URLRequestContextAdapter* adapter =

	156 reinterpret_cast<URLRequestContextAdapter*>(urlRequestContextAdapter);

	157 adapter->InitRequestContextOnUIThread();

	158 }

	159

150 } // namespace cronet	160 } // namespace cronet

OLD	NEW