Setup ProxyConfigServiceAndroid in Cronet

components/cronet/android/url_request_context_adapter.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/cronet/android/url_request_context_adapter.h"
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/single_thread_task_runner.h"
 #include "components/cronet/url_request_context_config.h"
 #include "net/base/net_errors.h"
 #include "net/base/net_log_logger.h"
 #include "net/cert/cert_verifier.h"
 #include "net/http/http_auth_handler_factory.h"
 #include "net/http/http_network_layer.h"
 #include "net/http/http_server_properties.h"
-#include "net/proxy/proxy_config_service_fixed.h"
+#include "net/proxy/proxy_config_service.h"
 #include "net/proxy/proxy_service.h"
 #include "net/ssl/ssl_config_service_defaults.h"
 #include "net/url_request/static_http_user_agent_settings.h"
 #include "net/url_request/url_request_context_builder.h"
 #include "net/url_request/url_request_context_storage.h"
 #include "net/url_request/url_request_job_factory_impl.h"
 
 namespace {
 
 class BasicNetworkDelegate : public net::NetworkDelegate {
@@ skipping 90 matching lines @@
   delegate_ = delegate;
   user_agent_ = user_agent;
 }
 
 void URLRequestContextAdapter::Initialize(
     scoped_ptr<URLRequestContextConfig> config) {
   network_thread_ = new base::Thread("network");
   base::Thread::Options options;
   options.message_loop_type = base::MessageLoop::TYPE_IO;
   network_thread_->StartWithOptions(options);
+  config_ = config.Pass();
 
+  delegate_->InitProxyConfigService();
+}
+
+// Called on application's main UI thread.
+void URLRequestContextAdapter::InitProxyConfigServiceOnUIThread() {
+  if (!base::MessageLoop::current()) {
+    main_message_loop_.reset(new base::MessageLoopForUI);
+    base::MessageLoopForUI::current()->Start();

[mmenke, 2014/10/02 16:17:26]

I hadn't realized it was so easy to set up a base::MessagePump on a Java thread.
 That's pretty nifty.

+  }
+  net::ProxyConfigService* service =
+      net::ProxyService::CreateSystemProxyConfigService(GetNetworkTaskRunner(),
+                                                        NULL);
+  proxy_config_service_.reset(service);

[mmenke, 2014/10/02 16:17:25]

Hrm...So we ensure that the Java URLRequestContext is still alive at this point
because posting the task Java-side holds onto a reference to the object, and we
ensure that the URLRequestContextAdapter is kept alive by a reference being
owned by the task...  A bit ugly, but it workw.

[xunjieli, 2014/10/02 17:21:31]

I am open to suggestions :) There is probably a better way.

   GetNetworkTaskRunner()->PostTask(
       FROM_HERE,
       base::Bind(&URLRequestContextAdapter::InitializeURLRequestContext,
                  this,
-                 Passed(&config)));
+                 Passed(&config_)));
 }
 
 void URLRequestContextAdapter::InitializeURLRequestContext(
     scoped_ptr<URLRequestContextConfig> config) {

[mmenke, 2014/10/02 16:17:25]

What happens if the embedder tries to use the URLRequestContextAdapter before
InitializeURLRequestContext has been called?

[xunjieli, 2014/10/02 17:21:31]

I guess they will have a context-not-setup error just like before? 

   // TODO(mmenke):  Add method to have the builder enable SPDY.
   net::URLRequestContextBuilder context_builder;
   context_builder.set_network_delegate(new BasicNetworkDelegate());
-  context_builder.set_proxy_config_service(
-      new net::ProxyConfigServiceFixed(net::ProxyConfig()));
+  context_builder.set_proxy_config_service(proxy_config_service_.get());
   config->ConfigureURLRequestContextBuilder(&context_builder);
 
   context_.reset(context_builder.Build());
 
   // Currently (circa M39) enabling QUIC requires setting probability threshold.
   if (config->enable_quic) {
     context_->http_server_properties()
         ->SetAlternateProtocolProbabilityThreshold(1.0f);
     for (size_t hint = 0; hint < config->quic_hints.size(); ++hint) {
       const URLRequestContextConfig::QuicHint& quic_hint =
@@ skipping 83 matching lines @@
     net_log_logger_.reset();
   }
 }
 
 void NetLogObserver::OnAddEntry(const net::NetLog::Entry& entry) {
   VLOG(2) << "Net log entry: type=" << entry.type()
           << ", source=" << entry.source().type << ", phase=" << entry.phase();
 }
 
 }  // namespace cronet