Issue 624433002: [Cherry-pick of 3a49520696b2eca69e57884657d23fd2402ccfd1.]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 624433002: [Cherry-pick of 3a49520696b2eca69e57884657d23fd2402ccfd1.] (Closed)

Created:
6 years, 2 months ago by Stephen White

Modified:
6 years, 2 months ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@m39

Project:
skia

Visibility:
Public.

[Cherry-pick of 3a49520696b2eca69e57884657d23fd2402ccfd1.] Sanitize SkMatrixConvolutionImageFilter creation params. Apply the same memory limit in the Create() function that we do when deserializing. TBR=reed@google.com Author: senorblanco@chromium.org Review URL: https://codereview.chromium.org/610723002 BUG=skia: Committed: https://skia.googlesource.com/skia/+/aafcb54f27d30c63602a0a0232f0b9fc8b310d19

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -10 lines)			Patch
M	include/effects/SkMatrixConvolutionImageFilter.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/effects/SkMatrixConvolutionImageFilter.cpp	View	4 chunks	+31 lines, -5 lines	0 comments	Download
M	tests/ImageFilterTest.cpp	View	1 chunk	+54 lines, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

Stephen White

6 years, 2 months ago (2014-10-01 18:06:00 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aafcb54f27d30c63602a0a0232f0b9fc8b310d19.