Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: net/third_party/nss/ssl/ssl3ext.c

Issue 62443004: net: add padding extension to all handshakes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/third_party/nss/ssl/ssl3ext.c
diff --git a/net/third_party/nss/ssl/ssl3ext.c b/net/third_party/nss/ssl/ssl3ext.c
index 8be042ed6a752f0fdaf1160112a2d5797ee4160b..9afc13e4beac20a86eeef4789dd5bd73ec7933bb 100644
--- a/net/third_party/nss/ssl/ssl3ext.c
+++ b/net/third_party/nss/ssl/ssl3ext.c
@@ -2306,7 +2306,11 @@ ssl3_CalculatePaddingExtensionLength(unsigned int clientHelloLength)
clientHelloLength;
unsigned int extensionLength;
- if (recordLength < 256 || recordLength >= 512) {
+ // This condition should be:
+ // if (recordLength < 256 || recordLength >= 512) {
+ // It has been changed, temporarily, to test whether 512 byte ClientHellos
+ // are a compatibility problem.
wtc 2013/11/11 19:36:37 Use the pre-C99 comment delimiters /* */ to be saf
agl 2013/11/12 16:34:52 Done.
+ if (recordLength >= 512) {
return 0;
}
@@ -2327,7 +2331,7 @@ ssl3_AppendPaddingExtension(sslSocket *ss, unsigned int extensionLen,
PRUint32 maxBytes)
{
unsigned int paddingLen = extensionLen - 4;
- unsigned char padding[256];
+ unsigned char padding[512];
if (extensionLen == 0) {
return 0;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698