net: add padding extension to all handshakes.

net: add padding extension to all handshakes.

This, temporary, change adds the padding extension to all handshakes to check
whether we encounter any servers with problems.

BUG=315828
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234850

[wtc, 2013-11-11 19:36:37]

Patch set 1 LGTM. Note that the CL needs work.

1. It needs a patch file.

2. I found two problems with the return value of ssl3_AppendPaddingExtension in
the previous CL. I can take care of that if you are busy.

https://codereview.chromium.org/62443004/diff/1/net/third_party/nss/ssl/ssl3e...
File net/third_party/nss/ssl/ssl3ext.c (right):

https://codereview.chromium.org/62443004/diff/1/net/third_party/nss/ssl/ssl3e...
net/third_party/nss/ssl/ssl3ext.c:2312: // are a compatibility problem.

Use the pre-C99 comment delimiters /* */ to be safe.

https://codereview.chromium.org/62443004/diff/1/net/third_party/nss/ssl/ssl3e...
net/third_party/nss/ssl/ssl3ext.c:2329: unsigned int

BUG: the return type should be signed. I suggest PRInt32 to match the return
type of ssl3_CallHelloExtensionSenders.

https://codereview.chromium.org/62443004/diff/1/net/third_party/nss/ssl/ssl3e...
net/third_party/nss/ssl/ssl3ext.c:2344: return 0;

Hmm... perhaps we should return -1 in this case.

[agl, 2013-11-12 16:34:52]

I wasn't going to add a patch file since this is temporary, but have done so.

(This will need the other patch to get through the CQ.)

https://codereview.chromium.org/62443004/diff/1/net/third_party/nss/ssl/ssl3e...
File net/third_party/nss/ssl/ssl3ext.c (right):

https://codereview.chromium.org/62443004/diff/1/net/third_party/nss/ssl/ssl3e...
net/third_party/nss/ssl/ssl3ext.c:2312: // are a compatibility problem.
On 2013/11/11 19:36:37, wtc wrote:
> 
> Use the pre-C99 comment delimiters /* */ to be safe.

Done.

https://codereview.chromium.org/62443004/diff/1/net/third_party/nss/ssl/ssl3e...
net/third_party/nss/ssl/ssl3ext.c:2329: unsigned int
On 2013/11/11 19:36:37, wtc wrote:
> 
> BUG: the return type should be signed. I suggest PRInt32 to match the return
> type of ssl3_CallHelloExtensionSenders.

Done.

https://codereview.chromium.org/62443004/diff/1/net/third_party/nss/ssl/ssl3e...
net/third_party/nss/ssl/ssl3ext.c:2344: return 0;
On 2013/11/11 19:36:37, wtc wrote:
> 
> Hmm... perhaps we should return -1 in this case.

Done.

[wtc, 2013-11-12 17:59:01]

Patch set 2 LGTM.

https://codereview.chromium.org/62443004/diff/60001/net/third_party/nss/patch...
File net/third_party/nss/patches/applypatches.sh (right):

https://codereview.chromium.org/62443004/diff/60001/net/third_party/nss/patch...
net/third_party/nss/patches/applypatches.sh:71: patch -p4 <
$patches_dir/paddingextensionall.patch

Please add this patch to README.chromium, listing it under
patches/paddingextension.patch.

[commit-bot: I haz the power, 2013-11-12 22:08:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/62443004/110001

[commit-bot: I haz the power, 2013-11-12 23:36:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/62443004/110001

[commit-bot: I haz the power, 2013-11-13 00:58:13]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[agl, 2013-11-13 17:14:11]

https://codereview.chromium.org/62443004/diff/60001/net/third_party/nss/patch...
File net/third_party/nss/patches/applypatches.sh (right):

https://codereview.chromium.org/62443004/diff/60001/net/third_party/nss/patch...
net/third_party/nss/patches/applypatches.sh:71: patch -p4 <
$patches_dir/paddingextensionall.patch
On 2013/11/12 17:59:01, wtc wrote:
> 
> Please add this patch to README.chromium, listing it under
> patches/paddingextension.patch.

Done.

[commit-bot: I haz the power, 2013-11-13 17:15:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/62443004/110001

[commit-bot: I haz the power, 2013-11-13 18:08:46]

Change committed as 234850