runtime/vm/flow_graph_compiler_ia32.cc - Issue 62443002: VM: Fix double comparisons using != and NaN in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 62443002: VM: Fix double comparisons using != and NaN in optimized code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_ia32.cc

===================================================================

--- runtime/vm/flow_graph_compiler_ia32.cc (revision 29983)

+++ runtime/vm/flow_graph_compiler_ia32.cc (working copy)

@@ -1624,7 +1624,9 @@

assembler()->comisd(left, right);

Label is_false, is_true, done;

- assembler()->j(PARITY_EVEN, &is_false, Assembler::kNearJump); // NaN false;

+ // x == NaN -> false, x != NaN -> true.

+ Label* nan_label = (true_condition == NOT_EQUAL) ? &is_true : &is_false;

+ assembler()->j(PARITY_EVEN, nan_label, Assembler::kNearJump);

assembler()->j(true_condition, &is_true, Assembler::kNearJump);

assembler()->Bind(&is_false);

assembler()->LoadObject(result, Bool::False());

« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »