runtime/vm/flow_graph_compiler_arm.cc - Issue 62443002: VM: Fix double comparisons using != and NaN in optimized code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 62443002: VM: Fix double comparisons using != and NaN in optimized code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler_arm.cc

===================================================================

--- runtime/vm/flow_graph_compiler_arm.cc (revision 29983)

+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)

@@ -1625,7 +1625,9 @@

assembler()->vmstat();

assembler()->LoadObject(result, Bool::False());

Label done;

- assembler()->b(&done, VS); // NaN -> false.

+ if (true_condition != NE) {

+ assembler()->b(&done, VS); // x == NaN -> false, x != NaN -> true.

+ }

assembler()->LoadObject(result, Bool::True(), true_condition);

assembler()->Bind(&done);

}

« no previous file with comments | « no previous file | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »