remove instrumentated task cycle detection

pkg/analyzer/lib/src/generated/engine.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // This code was auto-generated, is not intended to be edited, and is subject to
 // significant change. Please see the README file for more information.
 
 library engine;
 
 import 'dart:collection';
@@ skipping 910 matching lines @@
    */
   HashSet<Source> _neededForResolution = null;
 
   /**
    * A table mapping sources to the change notices that are waiting to be returned related to that
    * source.
    */
   HashMap<Source, ChangeNoticeImpl> _pendingNotices = new HashMap<Source, ChangeNoticeImpl>();
 
   /**
-   * A set containing information about the tasks that have been performed since the last change
-   * notification. Used to detect infinite loops in [performAnalysisTask].
-   */
-  LinkedHashSet<String> _recentTasks = new LinkedHashSet<String>();
-
-  /**
-   * A flag indicating whether we have already reported an infinite loop in
-   * [performAnalysisTask].
-   */
-  bool _reportedLoop = false;
-
-  /**
    * The object used to synchronize access to all of the caches. The rules related to the use of
    * this lock object are
    * * no analysis work is done while holding the lock, and
    * * no analysis results can be recorded unless we have obtained the lock and validated that the
    * results are for the same version (modification time) of the source as our current cache
    * content.
    */
   static Object _cacheLock = new Object();
 
   /**
@@ skipping 68 matching lines @@
       }
     }
     applyChanges(changeSet);
   }
 
   @override
   void applyChanges(ChangeSet changeSet) {
     if (changeSet.isEmpty) {
       return;
     }
-    _recentTasks.clear();
-    _reportedLoop = false;
     //
     // First, compute the list of sources that have been removed.
     //
     List<Source> removedSources = new List<Source>.from(changeSet.removedSources);
     for (SourceContainer container in changeSet.removedContainers) {
       _addSourcesInContainer(removedSources, container);
     }
     //
     // Then determine which cached results are no longer valid.
     //
@@ skipping 679 matching lines @@
     int getStart = JavaSystem.currentTimeMillis();
     AnalysisTask task = nextAnalysisTask;
     int getEnd = JavaSystem.currentTimeMillis();
     if (task == null && _validateCacheConsistency()) {
       task = nextAnalysisTask;
     }
     if (task == null) {
       return new AnalysisResult(_getChangeNotices(true), getEnd - getStart, null, -1);
     }
     String taskDescription = task.toString();
-    //    if (!reportedLoop && !recentTasks.add(taskDescription)) {
-    //      reportedLoop = true;
-    //      @SuppressWarnings("resource")
-    //      PrintStringWriter writer = new PrintStringWriter();
-    //      writer.print("Performing repeated task: ");
-    //      writer.println(taskDescription);
-    //      for (String description : recentTasks) {
-    //        writer.print("  ");
-    //        writer.println(description);
-    //      }
-    //      logInformation(writer.toString());
-    //    }
     _notifyAboutToPerformTask(taskDescription);
     if (_TRACE_PERFORM_TASK) {
       print(taskDescription);
     }
     int performStart = JavaSystem.currentTimeMillis();
     try {
       task.perform(_resultRecorder);
     } on ObsoleteSourceAnalysisException catch (exception) {
       AnalysisEngine.instance.logger.logInformation2("Could not perform analysis task: ${taskDescription}", exception);
     } on AnalysisException catch (exception) {
@@ skipping 132 matching lines @@
       int count = Math.min(sources.length, _options.cacheSize - _PRIORITY_ORDER_SIZE_DELTA);
       _priorityOrder = new List<Source>(count);
       for (int i = 0; i < count; i++) {
         _priorityOrder[i] = sources[i];
       }
     }
   }
 
   @override
   void setChangedContents(Source source, String contents, int offset, int oldLength, int newLength) {
-    _recentTasks.clear();
-    _reportedLoop = false;
     String originalContents = _contentCache.setContents(source, contents);
     if (contents != null) {
       if (contents != originalContents) {
         if (_options.incremental) {
           _incrementalAnalysisCache = IncrementalAnalysisCache.update(_incrementalAnalysisCache, source, originalContents, contents, offset, oldLength, newLength, _getReadableSourceEntry(source));
         }
         _sourceChanged(source);
         SourceEntryImpl sourceEntry = _cache.get(source);
         if (sourceEntry != null) {
           sourceEntry.modificationTime = _contentCache.getModificationStamp(source);
           sourceEntry.setValue(SourceEntry.CONTENT, contents);
         }
       }
     } else if (originalContents != null) {
       _incrementalAnalysisCache = IncrementalAnalysisCache.clear(_incrementalAnalysisCache, source);
       _sourceChanged(source);
     }
   }
 
   @override
   void setContents(Source source, String contents) {
-    _recentTasks.clear();
-    _reportedLoop = false;
     String originalContents = _contentCache.setContents(source, contents);
     if (contents != null) {
       if (contents != originalContents) {
         _incrementalAnalysisCache = IncrementalAnalysisCache.clear(_incrementalAnalysisCache, source);
         _sourceChanged(source);
         SourceEntryImpl sourceEntry = _cache.get(source);
         if (sourceEntry != null) {
           sourceEntry.modificationTime = _contentCache.getModificationStamp(source);
           sourceEntry.setValue(SourceEntry.CONTENT, contents);
         }
@@ skipping 1749 matching lines @@
         _workManager.add(source, SourcePriority.HTML);
       } else if (sourceEntry is DartEntry) {
         DartEntryImpl dartEntry = sourceEntry;
         oldPartMap[source] = dartEntry.getValue(DartEntry.INCLUDED_PARTS);
         dartEntry.invalidateAllResolutionInformation(invalidateUris);
         iterator.value = dartEntry;
         _workManager.add(source, _computePriority(dartEntry));
       }
     }
     _removeFromPartsUsingMap(oldPartMap);
-    _recentTasks.clear();
-    _reportedLoop = false;
   }
 
   /**
    * In response to a change to Angular entry point [HtmlElement], invalidate any results that
    * depend on it.
    *
    * <b>Note:</b> This method must only be invoked while we are synchronized on [cacheLock].
    *
    * <b>Note:</b> Any cache entries that were accessed before this method was invoked must be
    * re-accessed after this method returns.
@@ skipping 11537 matching lines @@
   void _advance() {
     _index++;
     if (_index >= _manager._workQueues[_queueIndex].length) {
       _index = 0;
       _queueIndex++;
       while (_queueIndex < _manager._workQueues.length && _manager._workQueues[_queueIndex].isEmpty) {
         _queueIndex++;
       }
     }
   }
-}
+}