Issue 6243004: Add GenerateSafePointTable, CallCode and EmitGoto to lithium codegen on x64...

Issue 6243004: Add GenerateSafePointTable, CallCode and EmitGoto to lithium codegen on x64... (Closed)

Created:
9 years, 11 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add GenerateSafePointTable, CallCode and EmitGoto to lithium codegen on x64 This enables empty function compilation with crankshaft.

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -5 lines)			Patch
	M	src/x64/lithium-codegen-x64.cc	View	1	4 chunks	+38 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Rico

http://codereview.chromium.org/6243004/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6243004/diff/1/src/x64/lithium-codegen-x64.cc#newcode542 src/x64/lithium-codegen-x64.cc:542: return; The return here is intentional to get the ...

9 years, 11 months ago (2011-01-17 09:36:02 UTC) #1

Lasse Reichstein

LGTM http://codereview.chromium.org/6243004/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6243004/diff/1/src/x64/lithium-codegen-x64.cc#newcode542 src/x64/lithium-codegen-x64.cc:542: return; Put this explanation in a comment and ...

9 years, 11 months ago (2011-01-17 09:38:56 UTC) #2

Rico

9 years, 11 months ago (2011-01-17 09:47:50 UTC) #3

Rico

9 years, 11 months ago (2011-01-17 09:57:43 UTC) #4

On 2011/01/17 09:47:50, Rico wrote:
> http://codereview.chromium.org/6243004/diff/1/src/x64/lithium-codegen-x64.cc
> File src/x64/lithium-codegen-x64.cc (right):
> 
>
http://codereview.chromium.org/6243004/diff/1/src/x64/lithium-codegen-x64.cc#...
> src/x64/lithium-codegen-x64.cc:542: return;
> On 2011/01/17 09:38:56, Lasse Reichstein wrote:
> > Put this explanation in a comment and remove the Abort.
> > Unreachable code is bad, m'kay.
> Changed to a comment and todo added
I will not commit this change since GC requires optimization data when a method
is optimized. I will create another patch including deoptimization data.

Expand Messages | Collapse Messages