Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/SecureRandomInitializer.java

Issue 624183002: Cleanup: Consolidate initialization of Android's SecureRandom class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/SecureRandomInitializer.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/SecureRandomInitializer.java b/remoting/android/java/src/org/chromium/chromoting/SecureRandomInitializer.java
deleted file mode 100644
index cf731ed31054de66a661a015a008c036a8abe013..0000000000000000000000000000000000000000
--- a/remoting/android/java/src/org/chromium/chromoting/SecureRandomInitializer.java
+++ /dev/null
@@ -1,41 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chromoting;
-
-import java.io.FileInputStream;
-import java.io.IOException;
-import java.security.SecureRandom;
-
-/**
- * This class contains code to initialize a SecureRandom generator securely on Android platforms
- * <= 4.3. See
- * {@link http://android-developers.blogspot.com/2013/08/some-securerandom-thoughts.html}.
- */
-public class SecureRandomInitializer {
- private static final int NUM_RANDOM_BYTES = 16;
-
- /**
- * Safely initializes the random number generator, by seeding it with data from /dev/urandom.
- */
- public static void initialize(SecureRandom generator) throws IOException {
- FileInputStream fis = null;
- try {
- fis = new FileInputStream("/dev/urandom");
- byte[] bytes = new byte[NUM_RANDOM_BYTES];
- if (bytes.length != fis.read(bytes)) {
- throw new IOException("Failed to get enough random data.");
- }
- generator.setSeed(bytes);
- } finally {
- try {
- if (fis != null) {
- fis.close();
- }
- } catch (IOException e) {
- // Ignore exception closing the device.
- }
- }
- }
-}

Powered by Google App Engine
This is Rietveld 408576698