Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 624153004: [webkitpy] Remove unused method from Environment class. (Closed)

Created:
6 years, 2 months ago by elecro
Modified:
6 years, 2 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[webkitpy] Remove unused method from Environment class. The disable_gcc_smartquotes was used during the build phase of webkit. This build phase is no longer in the webkitpy so we can safely remove it. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183400

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M Tools/Scripts/webkitpy/common/system/environment.py View 1 chunk +0 lines, -6 lines 0 comments Download
D Tools/Scripts/webkitpy/common/system/environment_unittest.py View 1 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
elecro
6 years, 2 months ago (2014-10-07 18:08:05 UTC) #4
Dirk Pranke
lgtm
6 years, 2 months ago (2014-10-08 01:38:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624153004/20001
6 years, 2 months ago (2014-10-08 08:15:54 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 09:27:09 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183400

Powered by Google App Engine
This is Rietveld 408576698