Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Issue 624153003: Add C++11 compatible base::hash function object. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add C++11 compatible base::hash function object. Implement NodeCache in terms of base::hash and std::equal_to in preparation for HeapConstant caching. TEST=cctest,unittests R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24412

Patch Set 1 #

Patch Set 2 : Use UINT64_C #

Patch Set 3 : Next try... #

Patch Set 4 : Fourth try... #

Patch Set 5 : Fix hashing of double/float. #

Patch Set 6 : Another one... #

Patch Set 7 : Final... #

Patch Set 8 : NodeCache #

Unified diffs Side-by-side diffs Delta from patch set Stats (+497 lines, -85 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A src/base/functional.h View 1 2 3 4 5 6 1 chunk +154 lines, -0 lines 0 comments Download
A src/base/functional.cc View 1 2 3 4 5 6 1 chunk +89 lines, -0 lines 0 comments Download
M src/compiler/node-cache.h View 1 2 3 4 5 6 7 3 chunks +27 lines, -15 lines 0 comments Download
M src/compiler/node-cache.cc View 1 2 3 4 5 6 7 4 chunks +41 lines, -62 lines 0 comments Download
A test/unittests/base/functional-unittest.cc View 1 2 3 4 5 1 chunk +131 lines, -0 lines 0 comments Download
M test/unittests/test-utils.h View 2 chunks +19 lines, -0 lines 0 comments Download
M test/unittests/test-utils.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M testing/gtest-support.h View 1 2 3 4 5 1 chunk +11 lines, -8 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-06 12:00:50 UTC) #2
Sven Panne
lgtm
6 years, 2 months ago (2014-10-06 12:26:34 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-06 12:27:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #8 (id:140001) manually as 24412 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698