chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 624153002: replace OVERRIDE and FINAL with override and final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 624153002: replace OVERRIDE and FINAL with override and final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api.h ('k') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index a98c89f60e8baf0d5ce49404c7d252f3d26e9bd4..47f7fa50445bfe537763062874ef2db1f6842439 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -302,7 +302,7 @@ class DownloadFileIconExtractorImpl : public DownloadFileIconExtractor {

virtual bool ExtractIconURLForPath(const base::FilePath& path,

float scale,

IconLoader::IconSize icon_size,

- IconURLCallback callback) OVERRIDE;

+ IconURLCallback callback) override;

private:

void OnIconLoadComplete(

float scale, const IconURLCallback& callback, gfx::Image* icon);

@@ -893,7 +893,7 @@ class ManagerDestructionObserver : public DownloadManager::Observer {

manager_->RemoveObserver(this);

}

- virtual void ManagerGoingDown(DownloadManager* manager) OVERRIDE {

+ virtual void ManagerGoingDown(DownloadManager* manager) override {

manager_file_existence_last_checked_->erase(manager);

if (manager_file_existence_last_checked_->size() == 0) {

delete manager_file_existence_last_checked_;