Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 624133003: Revert of [Invalidation Tracking] Trace StyleInvalidator setNeedsStyleRecalc (Closed)

Created:
6 years, 2 months ago by kouhei (in TOK)
Modified:
6 years, 2 months ago
Reviewers:
caseq, pdr., vivianz, yurys
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of [Invalidation Tracking] Trace StyleInvalidator setNeedsStyleRecalc (patchset #7 id:120001 of https://codereview.chromium.org/580373002/) Reason for revert: Regressed blink_perf.css Original issue's description: > [Invalidation Tracking] Trace StyleInvalidator setNeedsStyleRecalc > > This patch adds a set of trace events to track reason when > StyleInvalidator invokes Node::setNeedsStyleRecalc. One of the trace events is guaranteed to be issued before StyleInvalidator issues setNeedsStyleRecalc on the node. The trace events come with InspectorStyleInvalidatorInvalidateEvent, which contains inspector node id, human readable reason string, and optionally the tagName/id/class/attr/invalidationList involved. > > This is to be used from devtools so we post process and find the StyleInvalidator trace event on the given node to see the detailed reason for why StyleInvalidator decided issue setNeedsStyleRecalc on the node. > > BUG=410701 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183177 TBR=pdr@chromium.org,caseq@chromium.org,yurys@chromium.org BUG=410701, 420105 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -153 lines) Patch
M Source/core/css/invalidation/DescendantInvalidationSet.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/invalidation/DescendantInvalidationSet.cpp View 3 chunks +29 lines, -61 lines 0 comments Download
M Source/core/css/invalidation/StyleInvalidator.cpp View 4 chunks +3 lines, -12 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.h View 3 chunks +0 lines, -37 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 2 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kouhei (in TOK)
Created Revert of [Invalidation Tracking] Trace StyleInvalidator setNeedsStyleRecalc
6 years, 2 months ago (2014-10-04 04:39:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624133003/1
6 years, 2 months ago (2014-10-04 04:39:47 UTC) #3
pdr.
lgtm
6 years, 2 months ago (2014-10-04 04:44:44 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-04 05:43:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183227

Powered by Google App Engine
This is Rietveld 408576698