Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 624063002: <webview>: resizing with display:none set should resize on attachment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Istiaque's comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/guest_view/guest_view_container.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
index 908929a99da17b31d3bdf90481c036ff49a4b837..356fac39cdce57219c0436abe068f1f818532c91 100644
--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
@@ -64,13 +64,15 @@ void GuestViewInternalCustomBindings::AttachGuest(
static_cast<base::DictionaryValue*>(params_as_value.release()));
}
- guest_view_container->AttachGuest(
- element_instance_id,
- guest_instance_id,
- params.Pass(),
- args.Length() == 4 ? args[3].As<v8::Function>() :
- v8::Handle<v8::Function>(),
- args.GetIsolate());
+ linked_ptr<GuestViewContainer::AttachRequest> request(
+ new GuestViewContainer::AttachRequest(
+ element_instance_id,
+ guest_instance_id,
+ params.Pass(),
+ args.Length() == 4 ? args[3].As<v8::Function>() :
+ v8::Handle<v8::Function>(),
+ args.GetIsolate()));
+ guest_view_container->AttachGuest(request);
args.GetReturnValue().Set(v8::Boolean::New(context()->isolate(), true));
}
« no previous file with comments | « extensions/renderer/guest_view/guest_view_container.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698