Issue 624043002: Add openjpeg pre-processor OPJ_STATIC to pdfium.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 624043002: Add openjpeg pre-processor OPJ_STATIC to pdfium.gyp (Closed)

Created:
6 years, 2 months ago by Bo Xu

Modified:
6 years, 2 months ago

Reviewers:
Tom Sepez, Nico, jun_fang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

Add openjpeg pre-processor OPJ_STATIC to pdfium.gyp Openjpeg removed the definition of OPJ_STATIC in openjpeg.h. This change is merged in https://pdfium.googlesource.com/pdfium/+/d53e6fdb0a86ca1ddb12876a60f7f2d7508b5349 So need to add OPJ_STATIC to pdfium.gyp BUG=None R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/043f07f7c25af0064d093781106a12c3c749a50f

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pdfium.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Bo Xu

6 years, 2 months ago (2014-10-03 18:06:42 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
043f07f7c25af0064d093781106a12c3c749a50f (presubmit successful).