Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 624033003: [WIP] Move Web Notifications to a WebFrame-less code path (Blink). (Closed)

Created:
6 years, 2 months ago by Peter Beverloo
Modified:
6 years, 1 month ago
Reviewers:
Project:
blink
Visibility:
Public.

Description

[WIP] Move Web Notifications to a WebFrame-less code path. Blink patch: [THIS] Chromium patch: https://codereview.chromium.org/626973002/ Design document: http://goo.gl/IozoyA BUG=

Patch Set 1 #

Patch Set 2 : checkpoint #

Patch Set 3 : add tests #

Patch Set 4 : current state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+332 lines, -825 lines) Patch
M LayoutTests/fast/notifications/notification-click.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/fast/notifications/notification-click-dedicated-worker.html View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A LayoutTests/fast/notifications/notification-click-dedicated-worker-expected.txt View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/notifications/notification-click-expected.txt View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
A + LayoutTests/fast/notifications/notification-click-shared-worker.html View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
A LayoutTests/fast/notifications/notification-click-shared-worker-expected.txt View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M LayoutTests/fast/notifications/notification-click-window-focus-expected.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/notifications/notification-close.html View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
A + LayoutTests/fast/notifications/notification-close-dedicated-worker.html View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
A LayoutTests/fast/notifications/notification-close-dedicated-worker-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/fast/notifications/notification-close-expected.txt View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
A + LayoutTests/fast/notifications/notification-close-shared-worker.html View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
A LayoutTests/fast/notifications/notification-close-shared-worker-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/fast/notifications/notification-replace.html View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
A + LayoutTests/fast/notifications/notification-replace-dedicated-worker.html View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A LayoutTests/fast/notifications/notification-replace-dedicated-worker-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/fast/notifications/notification-replace-expected.txt View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
A + LayoutTests/fast/notifications/notification-replace-shared-worker.html View 1 2 1 chunk +5 lines, -5 lines 0 comments Download
A LayoutTests/fast/notifications/notification-replace-shared-worker-expected.txt View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M LayoutTests/fast/notifications/notifications-constructor-with-permission.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/fast/notifications/notifications-constructor-with-permission-dedicated-worker.html View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-constructor-with-permission-dedicated-worker-expected.txt View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/notifications/notifications-constructor-with-permission-expected.txt View 1 2 1 chunk +1 line, -2 lines 0 comments Download
A + LayoutTests/fast/notifications/notifications-constructor-with-permission-shared-worker.html View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-constructor-with-permission-shared-worker-expected.txt View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/notifications/notifications-constructor-without-permission.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/fast/notifications/notifications-constructor-without-permission-dedicated-worker.html View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-constructor-without-permission-dedicated-worker-expected.txt View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/notifications/notifications-constructor-without-permission-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/fast/notifications/notifications-constructor-without-permission-shared-worker.html View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A LayoutTests/fast/notifications/notifications-constructor-without-permission-shared-worker-expected.txt View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M LayoutTests/fast/notifications/resources/notification-click.js View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M LayoutTests/fast/notifications/resources/notification-close.js View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
M LayoutTests/fast/notifications/resources/notification-display.js View 1 2 1 chunk +7 lines, -4 lines 0 comments Download
M LayoutTests/fast/notifications/resources/notification-replace.js View 1 2 2 chunks +6 lines, -2 lines 0 comments Download
A LayoutTests/fast/notifications/resources/notification-worker.js View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/fast/notifications/resources/worker-tools.js View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/notifications/Notification.h View 1 2 6 chunks +12 lines, -10 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 2 8 chunks +47 lines, -40 lines 0 comments Download
M Source/modules/notifications/Notification.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
D Source/modules/notifications/NotificationClient.h View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/modules/notifications/NotificationController.h View 1 2 1 chunk +0 lines, -62 lines 0 comments Download
D Source/modules/notifications/NotificationController.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 2 3 3 chunks +0 lines, -6 lines 0 comments Download
M Source/web/NotificationPermissionClientImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
D Source/web/NotificationPresenterImpl.h View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
D Source/web/NotificationPresenterImpl.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
D Source/web/WebNotification.cpp View 1 chunk +0 lines, -124 lines 0 comments Download
M Source/web/web.gypi View 1 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M public/platform/WebNotificationManager.h View 1 2 3 3 chunks +32 lines, -6 lines 0 comments Download
M public/web/WebFrameClient.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
D public/web/WebNotification.h View 1 chunk +0 lines, -120 lines 0 comments Download
D public/web/WebNotificationPresenter.h View 1 chunk +0 lines, -70 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698