Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 624033002: Make unicode-bidi:isolate the default for block elements instead of unicode-bidi:embed

Created:
6 years, 2 months ago by h.joshi
Modified:
6 years, 2 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Relanding patch: https://codereview.chromium.org/61733019/ HTML5 specifies that block elements are supposed to have unicode-bidi: isolate by default. CSSDefaultStyleSheets.cpp: After this change, div elements can not use the simple stylesheet anymore. html.css is using the rules specified in http://www.w3.org/html/wg/drafts/html/master/rendering.html#bidirectional-text BUG=296863 TEST=fast/text/international/unicode-bidi-isolate-block-elements.html

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/international/unicode-bidi-isolate-block-elements.html View 1 chunk +134 lines, -0 lines 0 comments Download
M Source/core/css/html.css View 2 chunks +8 lines, -4 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 2 chunks +57 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698