Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 624023003: check pointer overflow in t2.c (Closed)

Created:
4 years, 11 months ago by Bo Xu
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.c View 1 1 chunk +1 line, -1 line 2 comments Download
M core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/t2.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (1 generated)
Bo Xu
Hi Tom, some discussion of this fix is here https://code.google.com/p/openjpeg/issues/detail?id=390. Seems the original check was ...
4 years, 11 months ago (2014-10-03 18:35:59 UTC) #2
Tom Sepez
Heh. I don't have permission to see the upstream issue. I can review this on ...
4 years, 11 months ago (2014-10-03 18:38:26 UTC) #3
Tom Sepez
LGTM. This is similar to something I suggested on one of the other code reivews, ...
4 years, 11 months ago (2014-10-03 18:41:00 UTC) #4
Tom Sepez
https://codereview.chromium.org/624023003/diff/20001/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.c File core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.c (right): https://codereview.chromium.org/624023003/diff/20001/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.c#newcode1283 core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.c:1283: /* ISO/IEC 15444-1:2004 (E), Table I.9 Legal METH values: ...
4 years, 11 months ago (2014-10-03 18:41:10 UTC) #5
Bo Xu
On 2014/10/03 18:38:26, Tom Sepez wrote: > Heh. I don't have permission to see the ...
4 years, 11 months ago (2014-10-03 18:41:30 UTC) #6
Tom Sepez
> Basically they referred to this article: http://lwn.net/Articles/278137/ > I am curious what would be ...
4 years, 11 months ago (2014-10-03 18:49:41 UTC) #7
Tom Sepez
> Generally, you want to represent sizes as size_t's and compare sizes against > each ...
4 years, 11 months ago (2014-10-03 18:56:21 UTC) #8
Bo Xu
On 2014/10/03 18:56:21, Tom Sepez wrote: > > Generally, you want to represent sizes as ...
4 years, 11 months ago (2014-10-03 19:08:22 UTC) #9
Bo Xu
https://codereview.chromium.org/624023003/diff/20001/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.c File core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.c (right): https://codereview.chromium.org/624023003/diff/20001/core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.c#newcode1283 core/src/fxcodec/fx_libopenjpeg/libopenjpeg20/jp2.c:1283: /* ISO/IEC 15444-1:2004 (E), Table I.9 Legal METH values: ...
4 years, 11 months ago (2014-10-03 19:08:38 UTC) #10
Tom Sepez
> I got the warning of "the file contains a character that cannot be represented ...
4 years, 11 months ago (2014-10-03 19:13:21 UTC) #11
Bo Xu
On 2014/10/03 19:13:21, Tom Sepez wrote: > > I got the warning of "the file ...
4 years, 11 months ago (2014-10-03 19:19:11 UTC) #12
Bo Xu
4 years, 11 months ago (2014-10-03 19:29:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e93d5341d87c54713a9632c8823288fa901a3b78 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698