Classes: Add support for toString

Classes: Add support for toString

BUG=v8:3330
LOG=Y
R=dslomov@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24472

[arv (Not doing code reviews), 2014-10-03 21:16:55]

Patchset #1 (id:1) has been deleted

[arv (Not doing code reviews), 2014-10-03 21:18:20]

arv@chromium.org changed reviewers:
+ adamk@chromium.org, dslomov@chromium.org

[arv (Not doing code reviews), 2014-10-03 21:18:21]

This implements toString by adding a bunch of private own properties to the
constructor function.

I'm not too happy with this solution but I didn't want to make all functions
larger to handle this use case.

Any suggestions?

[Dmitry Lomov (no reviews), 2014-10-07 10:31:13]

This approach seems fine to me.
Patch looking good but I'd like to review again once classes codegen lands and
this is rebased on top.

[arv (Not doing code reviews), 2014-10-07 16:48:58]

git rebase

[arv (Not doing code reviews), 2014-10-07 16:59:20]

PTAL

Here is background on how I got to where I am.

At first I thought I could just set the start_position and end_position on the
SharedFunctionInfo. That does not work because the position is used by the lazy
compilation so the second time when it tries to parse the function body it sees
"class".

So I thought I can just store the position and get the script source file from
the constructor. That also fails because if there is no constructor we use a
generated constructor which does not point back to the script.

So, to return the source we need to store script, start and end position on the
function object.

[Dmitry Lomov (no reviews), 2014-10-08 09:43:59]

looking good, just one comment

https://codereview.chromium.org/624013005/diff/40001/src/runtime/runtime-clas...
File src/runtime/runtime-classes.cc (right):

https://codereview.chromium.org/624013005/diff/40001/src/runtime/runtime-clas...
src/runtime/runtime-classes.cc:279: source,
Handle<Smi>::cast(start_position)->value(),
Some defensive programming here: check that start_position and end_position are
Smis and ThrowIllegalOperation otherwise.

[arv (Not doing code reviews), 2014-10-08 14:00:24]

Add type checks

[arv (Not doing code reviews), 2014-10-08 14:00:32]

https://codereview.chromium.org/624013005/diff/40001/src/runtime/runtime-clas...
File src/runtime/runtime-classes.cc (right):

https://codereview.chromium.org/624013005/diff/40001/src/runtime/runtime-clas...
src/runtime/runtime-classes.cc:279: source,
Handle<Smi>::cast(start_position)->value(),
On 2014/10/08 09:43:59, Dmitry Lomov (chromium) wrote:
> Some defensive programming here: check that start_position and end_position
are
> Smis and ThrowIllegalOperation otherwise.

Done.

[Dmitry Lomov (no reviews), 2014-10-08 14:09:39]

lgtm

[arv (Not doing code reviews), 2014-10-08 14:48:58]

Committed patchset #3 (id:60001) manually as 24472 (presubmit successful).