Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 623933005: ARIA role marquee should have ROLE_SYSTEM_ANIMATION as MSSA+IA2 role (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ARIA role marquee should have ROLE_SYSTEM_ANIMATION as MSSA+IA2 role According to specs(http://www.w3.org/WAI/PF/aria-implementation/) ARIA role marquee should have following MSSA+IA2 role and other IA2 features ROLE_SYSTEM_ANIMATION + IAccessible2: object attribute xml-roles:marquee;container-live:off;live:off BUG=421301 Committed: https://crrev.com/e59a002337a4fd651b08a8b423d873cef8ddff75 Cr-Commit-Position: refs/heads/master@{#298672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/test/data/accessibility/aria-marquee.html View 1 chunk +7 lines, -2 lines 0 comments Download
M content/test/data/accessibility/aria-marquee-expected-mac.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/aria-marquee-expected-win.txt View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks
6 years, 2 months ago (2014-10-08 05:13:34 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-08 06:59:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/623933005/1
6 years, 2 months ago (2014-10-08 07:00:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as bb15d12276cd10dd809117e5518da34ae93cb5fd
6 years, 2 months ago (2014-10-08 08:03:20 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 08:04:22 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e59a002337a4fd651b08a8b423d873cef8ddff75
Cr-Commit-Position: refs/heads/master@{#298672}

Powered by Google App Engine
This is Rietveld 408576698